Skip to content

fix(behat): retain escaped jq string assertions after removing legacy wrapper #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 2 commits into from
Nov 4, 2026
Merged

fix(behat): retain escaped jq string assertions after removing legacy wrapper #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
067c501
test(behat): reproduce escaped jq string regression
vitormattos Nov 2, 2026
07125ef
fix(behat): restore jq escaped string compatibility
vitormattos Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions features/test.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,3 +346,13 @@ Feature: Test this extension
"""
scanned=1
"""

Scenario: Test jq JSON strings preserve escaped quotes
When set the response to:
"""
{"data":{"policy":{"value":"{\"allowGroups\":[\"reviewers\"],\"denyGroups\":[]}"}}}
"""
And sending "POST" to "/"
Then the response should be a JSON array with the following mandatory values
| key | value |
| (jq).data.policy.value | {\"allowGroups\":[\"reviewers\"],\"denyGroups\":[]} |
4 changes: 4 additions & 0 deletions src/NextcloudApiContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,10 @@ private function runJsonQuery(string $json, string $filter): mixed {
$process->mustRun();
$output = trim($process->getOutput());
$decoded = json_decode($output, true);
if (is_string($decoded)) {
// Preserve the escaped jq string representation used by the legacy mapper.
return substr($output, 1, -1);
}
return json_last_error() === JSON_ERROR_NONE ? $decoded : $output;
}

Expand Down
Loading