Repository navigation
fix(env): align upright reward with quaternion inverse - #2589
Merged
Merged
Conversation
Replace the hand-rolled inverse-rotation formula with the shared quat_apply_inverse primitive. Keep the quaternion as the read-plan tensor and materialize the immutable gravity table on env.device. The regression fixture combines a mixed-axis rotation with non-axis-aligned gravity so both cross-product terms are exercised. No in-tree task configuration currently enables mdp.upright.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mdp.uprightwith the sharedquat_apply_inverseprimitive.env.device.For the usual flat-ground gravity vector
(0, 0, -1), the old formula's horizontal squared norm happens to match the standard result; the projected vector itself remains wrong. Non-axis-aligned gravity exposes the numerical difference. No in-tree task configuration currently enablesmdp.upright, so there is no in-tree task requiring a retraining regression.Linked Work
dev/issue-2583-unify-math-rotation(roadmap now merged intomain)mainValidation
make test-allpassed on the final local head before this PR was created or updatedCommands actually run:
Results:
Remote CI route:
main: current-head CI link/status: pending at PR creation.Impact
Artifacts
Checklist