Repository navigation
Remove the stale benchmark chart - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only. Follows #14, which merged just before this commit landed.
Why
assets/benchmarks.svgdraws "dhaar, one peer" at 4.3 MB/s. The figure isnow around 6, because removing the per-piece flush moved it. A picture asserting
a number that is 40% low is wrong regardless of what the prose around it says —
and prose is not what a reader takes from a chart.
The chart cannot simply be corrected. Its subtitle reads "Same machine, same
afternoon", which is the only thing making its four bars comparable to each
other. Editing one bar to today's value — which #13 did, and #14 reverted —
makes it claim one session while containing two. Redoing it honestly means
re-running all four bars together, and two of them need a live swarm and a
mirror to measure a real link against. That cannot be produced here.
So the chart goes, along with the comparison table it anchored. Every row in
that table was measured against a slower client: the 2.5 MB/s live-swarm figure
has the same problem as the 4.3, just less visibly.
What replaces it
Two sentences saying the measurement has not been redone, what the old figures
were, and what redoing it would require — a live swarm, a mirror, enough runs to
average out the ±20% a public swarm moves by, and all four numbers from one
session or the comparison between them means nothing.
The loopback and seeder benchmarks are unaffected. Those are reproducible here
and stay, with the ranges #14 gave them.
🤖 Generated with Claude Code