Skip to content

Remove the stale benchmark chart - #15

Merged
PiyushXCoder merged 1 commit into
masterfrom
optimise
Sep 16, 2026
Merged

PiyushXCoder merged 1 commit into
masterfrom
optimise

Conversation

@PiyushXCoder

Copy link
Copy Markdown
Owner

Documentation only. Follows #14, which merged just before this commit landed.

Why

assets/benchmarks.svg draws "dhaar, one peer" at 4.3 MB/s. The figure is
now around 6, because removing the per-piece flush moved it. A picture asserting
a number that is 40% low is wrong regardless of what the prose around it says —
and prose is not what a reader takes from a chart.

The chart cannot simply be corrected. Its subtitle reads "Same machine, same
afternoon"
, which is the only thing making its four bars comparable to each
other. Editing one bar to today's value — which #13 did, and #14 reverted —
makes it claim one session while containing two. Redoing it honestly means
re-running all four bars together, and two of them need a live swarm and a
mirror to measure a real link against. That cannot be produced here.

So the chart goes, along with the comparison table it anchored. Every row in
that table was measured against a slower client: the 2.5 MB/s live-swarm figure
has the same problem as the 4.3, just less visibly.

What replaces it

Two sentences saying the measurement has not been redone, what the old figures
were, and what redoing it would require — a live swarm, a mirror, enough runs to
average out the ±20% a public swarm moves by, and all four numbers from one
session or the comparison between them means nothing.

The loopback and seeder benchmarks are unaffected. Those are reproducible here
and stay, with the ranges #14 gave them.

🤖 Generated with Claude Code

Copilot AI lite review requested due to automatic review settings September 16, 2026 19:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@PiyushXCoder
PiyushXCoder merged commit eb874c7 into master Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants