Fix theme pull, push, and package to cover all theme files - #8528
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain, and the changes include test coverage.
Pull request overview
Updates theme synchronization and packaging to support config/styles.css and root AGENTS.md.
Changes:
- Discovers, synchronizes, and orders both files.
- Includes
AGENTS.mdin theme packages. - Adds fixtures, tests, and a patch changeset.
File summaries
| File | Summary |
|---|---|
packages/theme/src/cli/utilities/theme-uploader.ts |
Handles upload and deletion ordering. |
packages/theme/src/cli/utilities/theme-uploader.test.ts |
Tests synchronization behavior. |
packages/theme/src/cli/utilities/theme-fs.ts |
Discovers and classifies the new files. |
packages/theme/src/cli/utilities/theme-fs.test.ts |
Tests filesystem discovery and classification. |
packages/theme/src/cli/utilities/fixtures/theme/config/styles.css |
Adds stylesheet fixture. |
packages/theme/src/cli/utilities/fixtures/theme/AGENTS.md |
Adds instructions fixture. |
packages/theme/src/cli/services/package.ts |
Includes AGENTS.md in packages. |
packages/theme/src/cli/services/package.test.ts |
Tests package inclusion. |
.changeset/olive-themes-sync.md |
Documents the user-facing patch. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
karreiro
force-pushed
the
fix-theme-file-sync
branch
from
September 11, 2026 10:15
3cfb906 to
676fb66
Compare
EvilGenius13
approved these changes
Sep 11, 2026
The changelog entry is included in the patch release. Assisted-By: devx/29074a55-91ba-4446-80b3-c68f3d1345c2
karreiro
force-pushed
the
fix-theme-file-sync
branch
from
September 11, 2026 15:33
676fb66 to
7ee6fe2
Compare
Contributor
Author
|
(the changelog was applied in the patch counter part #8529) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The checksums API returns config/styles.css and AGENTS.md, but Shopify CLI does not handle them.
WHAT is this pull request doing?
Recognize config/styles.css and AGENTS.md during theme synchronization, and include both files in theme packages.
How to manually test your changes?
Run the following commands against a theme containing both files:
Notice that config/styles.css and AGENTS.md are pulled, pushed, and included in the generated package.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add