Skip to content

Fix theme pull, push, and package to cover all theme files - #8528

Merged
karreiro merged 1 commit into
mainfrom
fix-theme-file-sync
Sep 11, 2026
Merged

Fix theme pull, push, and package to cover all theme files#8528
karreiro merged 1 commit into
mainfrom
fix-theme-file-sync

Conversation

@karreiro

@karreiro karreiro commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The checksums API returns config/styles.css and AGENTS.md, but Shopify CLI does not handle them.

WHAT is this pull request doing?

Recognize config/styles.css and AGENTS.md during theme synchronization, and include both files in theme packages.

How to manually test your changes?

Run the following commands against a theme containing both files:

shopify theme pull
shopify theme push
shopify theme package

Notice that config/styles.css and AGENTS.md are pulled, pushed, and included in the generated package.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

@karreiro
karreiro requested a review from a team as a code owner September 11, 2026 10:06
Copilot AI lite review requested due to automatic review settings September 11, 2026 10:06
@github-actions github-actions Bot added the Area: @shopify/theme @shopify/theme package issues label Sep 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review comments remain, and the changes include test coverage.

Pull request overview

Updates theme synchronization and packaging to support config/styles.css and root AGENTS.md.

Changes:

  • Discovers, synchronizes, and orders both files.
  • Includes AGENTS.md in theme packages.
  • Adds fixtures, tests, and a patch changeset.
File summaries
File Summary
packages/theme/src/cli/utilities/theme-uploader.ts Handles upload and deletion ordering.
packages/theme/src/cli/utilities/theme-uploader.test.ts Tests synchronization behavior.
packages/theme/src/cli/utilities/theme-fs.ts Discovers and classifies the new files.
packages/theme/src/cli/utilities/theme-fs.test.ts Tests filesystem discovery and classification.
packages/theme/src/cli/utilities/fixtures/theme/config/styles.css Adds stylesheet fixture.
packages/theme/src/cli/utilities/fixtures/theme/AGENTS.md Adds instructions fixture.
packages/theme/src/cli/services/package.ts Includes AGENTS.md in packages.
packages/theme/src/cli/services/package.test.ts Tests package inclusion.
.changeset/olive-themes-sync.md Documents the user-facing patch.
Review details
  • Files reviewed: 9/9 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/theme/src/cli/services/package.test.ts
The changelog entry is included in the patch release.

Assisted-By: devx/29074a55-91ba-4446-80b3-c68f3d1345c2
@github-actions github-actions Bot added no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. and removed Area: @shopify/theme @shopify/theme package issues labels Sep 11, 2026
@karreiro

Copy link
Copy Markdown
Contributor Author

(the changelog was applied in the patch counter part #8529)

@karreiro
karreiro added this pull request to the merge queue Sep 11, 2026
Merged via the queue into main with commit 1be7733 Sep 11, 2026
30 checks passed
@karreiro
karreiro deleted the fix-theme-file-sync branch September 11, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants