Skip to content

[4.8] Fix theme pull, push, and package to cover all theme files - #8529

Merged
karreiro merged 1 commit into
stable/4.8from
fix-theme-file-sync-4.8
Sep 11, 2026
Merged

[4.8] Fix theme pull, push, and package to cover all theme files#8529
karreiro merged 1 commit into
stable/4.8from
fix-theme-file-sync-4.8

Conversation

@karreiro

Copy link
Copy Markdown
Contributor

Back-port #8528

@karreiro
karreiro requested a review from a team as a code owner September 11, 2026 10:11
@github-actions github-actions Bot added the Area: @shopify/theme @shopify/theme package issues label Sep 11, 2026
Assisted-By: devx/29074a55-91ba-4446-80b3-c68f3d1345c2
@karreiro
karreiro force-pushed the fix-theme-file-sync-4.8 branch from 1cf965e to d7abacf Compare September 11, 2026 10:15
@github-actions

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/custom-oclif-loader.d.ts
@@ -17,12 +17,6 @@ export declare class ShopifyConfig extends Config {
      * @param loader - The lazy command loader function.
      */
     setLazyCommandLoader(loader: LazyCommandLoader): void;
-    /**
-     * Override load to protect oclif's shell detection from a failing OS user lookup.
-     *
-     * @returns A promise that resolves once the config is loaded.
-     */
-    load(): Promise<void>;
     /**
      * Override runCommand to use lazy loading when available.
      * Instead of calling cmd.load() which triggers loading ALL commands via index.js,
packages/cli-kit/dist/public/node/fs.d.ts
@@ -114,26 +114,12 @@ export declare function mkdir(path: string): Promise<void>;
  * @param path - Path to the directory to be created.
  */
 export declare function mkdirSync(path: string): void;
-interface RemoveFileOptions {
-    /**
-     * Number of times Node retries the removal when it hits a transient error
-     * (EBUSY, EMFILE, ENFILE, ENOTEMPTY or EPERM), waiting `retryDelay` milliseconds
-     * longer on each try. Defaults to 0 (no retries).
-     */
-    maxRetries?: number;
-    /**
-     * Milliseconds to wait between retries. Defaults to 100.
-     */
-    retryDelay?: number;
-}
 /**
- * Removes a file or directory (recursively) at the given path.
+ * Removes a file at the given path.
  *
- * @param path - Path to the file or directory to be removed.
- * @param options - Retry behavior, passed through to Node's `fs.rm`. Useful when the removal can
- * race with transient locks, such as an antivirus scanning freshly written files.
+ * @param path - Path to the file to be removed.
  */
-export declare function removeFile(path: string, options?: RemoveFileOptions): Promise<void>;
+export declare function removeFile(path: string): Promise<void>;
 /**
  * Renames a file.
  * @param from - Path to the file to be renamed.

@karreiro
karreiro merged commit 3b6170d into stable/4.8 Sep 11, 2026
28 checks passed
@karreiro
karreiro deleted the fix-theme-file-sync-4.8 branch September 11, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/theme @shopify/theme package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants