[4.8] Fix theme pull, push, and package to cover all theme files - #8529
Merged
Conversation
Assisted-By: devx/29074a55-91ba-4446-80b3-c68f3d1345c2
karreiro
force-pushed
the
fix-theme-file-sync-4.8
branch
from
September 11, 2026 10:15
1cf965e to
d7abacf
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/custom-oclif-loader.d.ts@@ -17,12 +17,6 @@ export declare class ShopifyConfig extends Config {
* @param loader - The lazy command loader function.
*/
setLazyCommandLoader(loader: LazyCommandLoader): void;
- /**
- * Override load to protect oclif's shell detection from a failing OS user lookup.
- *
- * @returns A promise that resolves once the config is loaded.
- */
- load(): Promise<void>;
/**
* Override runCommand to use lazy loading when available.
* Instead of calling cmd.load() which triggers loading ALL commands via index.js,
packages/cli-kit/dist/public/node/fs.d.ts@@ -114,26 +114,12 @@ export declare function mkdir(path: string): Promise<void>;
* @param path - Path to the directory to be created.
*/
export declare function mkdirSync(path: string): void;
-interface RemoveFileOptions {
- /**
- * Number of times Node retries the removal when it hits a transient error
- * (EBUSY, EMFILE, ENFILE, ENOTEMPTY or EPERM), waiting `retryDelay` milliseconds
- * longer on each try. Defaults to 0 (no retries).
- */
- maxRetries?: number;
- /**
- * Milliseconds to wait between retries. Defaults to 100.
- */
- retryDelay?: number;
-}
/**
- * Removes a file or directory (recursively) at the given path.
+ * Removes a file at the given path.
*
- * @param path - Path to the file or directory to be removed.
- * @param options - Retry behavior, passed through to Node's `fs.rm`. Useful when the removal can
- * race with transient locks, such as an antivirus scanning freshly written files.
+ * @param path - Path to the file to be removed.
*/
-export declare function removeFile(path: string, options?: RemoveFileOptions): Promise<void>;
+export declare function removeFile(path: string): Promise<void>;
/**
* Renames a file.
* @param from - Path to the file to be renamed.
|
EvilGenius13
approved these changes
Sep 11, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back-port #8528