Repository navigation
feat(file-item): reuse compact shared cards on lp - #1531
Draft
yevheniia0831 wants to merge 7 commits into
Draft
yevheniia0831 wants to merge 7 commits into
yevheniia0831 wants to merge 7 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Oct 29, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1529.
Changes
da-file-item. Keep shared menus, favorites and Browse defaults.mdimension preset only. Keep the 80px preview and 197.6x142px S card at the reference width.Draft targeting
lp. Requires adobe/da-nx#934 first.Preview
Before: https://lp--da-live--adobe.aem.live/?nx=lp&nxver=2&landing=true&theme=light
After: https://fileitem--da-live--adobe.aem.live/?nx=lpcards&nxver=2&landing=true&theme=light
Testing
1,062 focused tests and JS/CSS lint passed. CI passed. Da-Admin Playwright passed.
Fixture checks passed for light/dark, S/M, chat open/closed, responsive layout, previews, favorites, menus, focus and site switching.
Commands and results
Passed: 1,062 tests across 38 files.
All passed.
Still to verify
Manual document previews after site selection. Helix Playwright was cancelled, not passed. S/M was tested at component level, not through the global control.