Skip to content

feat(file-item): reuse compact shared cards on lp - #1531

Draft
yevheniia0831 wants to merge 7 commits into
lpfrom
fileitem
Draft

yevheniia0831 wants to merge 7 commits into
lpfrom
fileitem

Conversation

@yevheniia0831

@yevheniia0831 yevheniia0831 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #1529.

Changes

  1. Replace LP card internals with shared da-file-item. Keep shared menus, favorites and Browse defaults.
  2. Use compact presentation and the existing m dimension preset only. Keep the 80px preview and 197.6x142px S card at the reference width.
  3. Preserve lazy image/document previews, navigation, filtering, pagination and site switching. Keep list columns unchanged.
  4. Tokenize matching card values without changing mock geometry. No page or chat redesign.

Draft targeting lp. Requires adobe/da-nx#934 first.

Preview

Before: https://lp--da-live--adobe.aem.live/?nx=lp&nxver=2&landing=true&theme=light

After: https://fileitem--da-live--adobe.aem.live/?nx=lpcards&nxver=2&landing=true&theme=light

Testing

1,062 focused tests and JS/CSS lint passed. CI passed. Da-Admin Playwright passed.

Fixture checks passed for light/dark, S/M, chat open/closed, responsive layout, previews, favorites, menus, focus and site switching.

Commands and results
node_modules/.bin/wtr --config web-test-runner.config.js --node-resolve --port=2114 --files 'test/unit/blocks/browse/**/*.test.js' --files 'test/unit/blocks/{landing,shared/da-file-item,shared/file-actions,canvas/ew-file-explorer}/**/*.test.js'

Passed: 1,062 tests across 38 files.

node_modules/.bin/eslint blocks/shared/da-file-item/da-file-item.js blocks/landing/landing.js test/unit/blocks/shared/da-file-item/da-file-item-preview.test.js test/unit/blocks/shared/da-file-item/da-file-item-render.test.js test/unit/blocks/shared/da-file-item/da-file-item.test.js test/unit/blocks/landing/landing.test.js
node_modules/.bin/stylelint blocks/shared/da-file-item/da-file-item.css blocks/landing/landing.css
git diff --check

All passed.

Still to verify

Manual document previews after site selection. Helix Playwright was cancelled, not passed. S/M was tested at component level, not through the global control.

Yevheniia Severinovska and others added 4 commits October 29, 2026 15:39
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@aem-code-sync

aem-code-sync Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@yevheniia0831 yevheniia0831 changed the title feat(file-item): share compact file cards and previews feat(file-item): reuse compact shared cards on lp Oct 29, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
fileitem — 020bb912 Deployed Oct 29, 2026 by aem-code-sync[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant