Repository navigation
feat(file-item): support contextual list columns - #1633
Draft
yevheniia0831 wants to merge 3 commits into
Draft
yevheniia0831 wants to merge 3 commits into
yevheniia0831 wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #1528.
Changes
The landing integration is separate, as with #1616 and #1531. No Browse controller is imported into landing. This branch starts from main and does not include landing UI.
Testing
Passed: 812 tests across 30 files. Includes default Browse regressions, custom cells, lazy and shared metadata requests, stale results, independent rows, failed requests, reactive updates and user icons at 20px in S and 22px in M.
node_modules/.bin/eslint blocks/shared/da-file-item/da-file-item.js test/unit/blocks/shared/da-file-item/*.test.js node_modules/.bin/stylelint blocks/shared/da-file-item/da-file-item.css git diff --check origin/main...HEADAll passed. Deployment check passed: both changed production JS/CSS files match the published preview branch.
Authenticated preview validation has not been run. Deployed Nexter main does not currently expose the UI-size controller, so local size checks do not prove a live M toggle.