Repository navigation
docs: constrain grpcio-tools in Planner installation examples - #249
Conversation
Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🧰 Additional context used📓 Path-based instructions (3)Check commands, defaults, supported runtimes, public names, and claims against executable behavior.⚙️ CodeRabbit configuration file Files:
Read REVIEW.md before commenting.⚙️ CodeRabbit configuration file Files:
Before making any change under: `python/aisimulate/src/aiconfigurator/generator/**` MUST read: `python/aisimulate/.claude/rules/generator-development.md` Before making any change under `python/aisimulate/collector/**` MUST read: `python/ais...📄 CodeRabbit inference engine (AGENTS.md) Files:
🔀 Multi-repo context ai-dynamo/dynamo, ai-dynamo/aiconfiguratorLinked repositories findingsai-dynamo/dynamo
ai-dynamo/aiconfigurator
🔇 Additional comments (2)
📝 SummaryRisk: Medium. Human attention should focus on:
The change affects only Planner installation documentation. It adds the The supplied checks exited successfully, but their output contains no diff details. The provided summary reports passing focused dependency, shell syntax, documentation destination, SPDX/legal-file, and whitespace checks. No current review severity findings were supplied. Technical quality is supported for the documented dependency change. Merge readiness remains incomplete. Exact Linux RC9 wheel validation, full Planner execution, hosted CI, NVIDIA runner admission, and human CODEOWNER approval are still pending. WalkthroughChangesPlanner dependency documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The Planner installation guidance is consistently updated in both documented entry points, with no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
Comment |
|
Self-review of published head The two commands now apply the RC9 common-requirements cap in the same resolver invocation as Planner's protobuf pin. Both documents scope the cap to that revision and explain how to update it for another revision. The focused Python 3.12 reproduction fails The exact Linux RC9 wheel setup remains a separate QA validation; this review does not substitute the focused dependency test for the full Planner run. No self-review correction threads were needed. Hosted review and CI remain pending, including normal NVIDIA runner admission. Human CODEOWNER approval remains required before merge. |
Why and what changed
This addresses the remaining dependency-installation issue reported in NVBug 6785216: [aisimulate][release/0.12.0][Docs] "With Dynamo" installation instructions omit Planner prerequisites. The original failure was
ModuleNotFoundError: No module named 'sklearn'when loading the Planner adapter after the basic wheel installation. Merged PR #231 documents the complete Planner prerequisites and adds a runnable CPU-only example.Following #231's installation steps can leave
pip checkfailing: AISimulate'sgoogle-vizierdependency can install a newergrpcio-tools, then the separate Planner requirements installation pins protobuf to6.33.6without constraining the already-installed tooling.Both Planner installation examples now include
"grpcio-tools<=1.76.0"in the same pip invocation as the matching Planner requirements. This matches Dynamo 1.5.0 RC9's common requirements atffd7c1a90eb403c0d43911690c5c9b8457acd826. The explanations link that source and tell readers to revisit the cap when changing Dynamo revisions.Review map
README.mdanddocs/cli/examples/dynamo-planner/README.md.Evidence
Qun Chi recorded in NVBug 6785216 comment 2 that the original documentation at
7ebe37aeeb826c61f60c16c56c536c8ab8f8afa2was verified in a fresh Python 3.12 environment using the exact AIS0.12.0.dev2and Dynamo RC9 QA wheels. The Planner CLI completed all 12 requests and generatedprediction.jsonandrequests.jsonl, butpip checkstill reported agrpcio-tools/protobufconflict. This PR addresses that remaining conflict; the QA result predates this correction.A focused, isolated Python 3.12.11 environment on macOS reproduced and repaired the dependency conflict:
bash -n.git diff --checkpass.pip check, 12 completed requests, and both output files.Modeling or data provenance
N/A; no simulation, performance data, or prediction changes.
Tracking
release/0.12.0; the correction from this PR must also reach that branch.release/0.12.0and QA verification with the exact matching wheels: cleanpip check, 12 completed requests, and both output files. Merging this main-branch PR alone does not close the bug.