Improve wallet sync throughput, binary transport, and checkpoint recovery - #486
Merged
Merged
Conversation
BraydenLangley
force-pushed
the
agent/wallet-sync-throughput
branch
6 times, most recently
from
August 17, 2026 21:57
568e029 to
3d420ab
Compare
BraydenLangley
force-pushed
the
agent/wallet-sync-throughput
branch
from
September 1, 2026 00:51
74ee852 to
3443b28
Compare
BraydenLangley
force-pushed
the
agent/wallet-sync-throughput
branch
from
September 8, 2026 21:39
a4c615b to
0367743
Compare
BraydenLangley
marked this pull request as ready for review
September 9, 2026 00:45
BraydenLangley
requested review from
sirdeggen,
tonesnotes and
ty-everett
as code owners
September 9, 2026 00:45
BraydenLangley
marked this pull request as draft
September 9, 2026 18:56
BraydenLangley
marked this pull request as ready for review
September 9, 2026 20:21
BraydenLangley
marked this pull request as draft
September 9, 2026 20:22
BraydenLangley
marked this pull request as ready for review
September 9, 2026 20:41
BraydenLangley
marked this pull request as draft
September 10, 2026 17:12
BraydenLangley
force-pushed
the
agent/wallet-sync-throughput
branch
from
September 10, 2026 17:55
afe5a64 to
70048ba
Compare
BraydenLangley
marked this pull request as ready for review
September 10, 2026 18:56
ty-everett
approved these changes
Sep 10, 2026
ty-everett
approved these changes
Sep 10, 2026
ty-everett
left a comment
Collaborator
There was a problem hiding this comment.
Approved for release after resolving the post-security-release version collision. Exact head 1cc9c61 targets fresh SDK 2.6.0 and Wallet Toolbox/Client/Mobile 2.13.0 candidates; local health, format, lint, build, and post-build typecheck gates pass. Merge remains contingent on all hosted exact-head checks succeeding.
|
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Results at a glance
Smaller transfers, resumable large records, durable checkpoints, and safer proof recovery.
The latest revision is deployed to a compatible backup provider; its complete source-to-backup retest remains pending the primary-provider upgrade. Earlier native results do not prove this follow-up completes the reported wallet backup. Timings compare successive candidates, not a controlled comparison against upstream
main; byte checks were sampled, not database-wide.Implementation, verification, and release boundaries
Program and scope
Rebased onto upstream
mainat7a9cca774a, then integrated the newly merged upstream security changes at99f5f5faa1. This repository usesmain, notmaster; the PR title is unchanged. Reviewed head: 4e81e20. The final follow-up changes only the measured Linux artifact allowance and documentation; runtime source is identical to the locally tested combined candidate.getValidatedMerklePathmethod. Raw transaction bytes and wallet references are preserved. Local correction timestamps enable onward incremental replication without advancing the source cursor past uncopied records.Impact and verification
Local verification (combined sync and upstream security candidate):
pnpm health:check,pnpm lint,pnpm format:check,pnpm typecheck.pnpm audit:security: existing governed audit policy passed; advisory dispositions unchanged. No new dependency override, quality suppression or finding-baseline waiver.The new authenticated regression checks 250 synthetic proofs, rejects an invalid next page without changing data/checkpoint, then resumes using a validated replacement. Both new and existing destination proof rows are covered. Read-only production diagnostics and local validation of source records supplement these fixtures; no production import or full-backup retest was performed for this follow-up.
Earlier native E2E additionally completed a fresh 134,240-record / 817-page device copy and exercised all six existing profiles with saved local copies. That run took 45m 29s and is completion evidence, not a speedup comparison. A separate bounded native sample measured foreground timer-delay p95 22ms, maximum 44ms. No offline spending or primary-promotion test was performed.
Portable budget changes include measured sync and upstream security costs. The artifact-cost table records macOS measurements and final raw/gzip/Brotli ceilings, including the earlier Linux compression allowance. SDK/browser/mobile composition and artifact checks passed locally; no Node storage backend was added to portable packages.
Dependency evidence
Release and operations
2026-09-09-001before advertising transfer version 1.syncTransfers: falsesupports staged rollout. Rollback must preserve current wallet data and reverse only the staging migration using the new runtime before reverting to incompatible older code; see the transfer guide.