Repository navigation
Fix short-lived Unix PTY initialization for v0.1.8 - #62
Merged
Merged
Conversation
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short-lived Unix PTY children can exit before ProcessTree::attach queries getpgid/getsid, causing a successful spawn to be rejected and its Created notification to be omitted. The macOS release tests exposed this while starting immediate printf/exit commands.
Derive the session and root process-group identity from the owned child PID: portable-pty establishes setsid before exec, and attach runs before any wait/reap. Retain the invalid-PID guard, TTY handle, Windows Job Object behavior and process-tree termination path.
Add a real-PTY Linux/macOS regression that uses waitid(WEXITED | WNOWAIT) to observe termination without reaping, then verifies attach and explicitly reaps the child. No tests are disabled.
Related to #61. Local Windows and Linux gates and independent custody review are required before merge; GitHub CI supplies native macOS verification. This is a v0.1.8 release blocker fix; no v0.1.8 tag or published Release exists yet.