FECFILE-2421: delete load test mirror data - #2292
Conversation
| except ValueError as error: | ||
| raise CommandError(str(error)) from error | ||
|
|
||
| load_test_utils.delete_load_test_committees_and_data() |
There was a problem hiding this comment.
any reason not to put this inside the try?
There was a problem hiding this comment.
validate_load_mirror_runtime() is in the try because I want to test that we're in the load mirror and capture/raise it as a sort of pre-flight error if we aren't, whereas if the actual delete fails I'm fine with it stacktracing all over the terminal.
Including it in the try maybe makes a lot of sense, though...
There was a problem hiding this comment.
I added a second try because I want to differentiate between the two sources of exceptions and handle them differently. Thoughts?
lbeaufort
left a comment
lbeaufort
left a comment
There was a problem hiding this comment.
Looks great, thanks for including tests!
|
4 participants
Ticket link:
https://fecgov.atlassian.net/browse/FECFILE-2421
Related PRs:
N/A
gen_locust_load_test_data,get_overviewto get the counts, thendelete_locust_load_test_data, thenget_overviewagain