Skip to content

Feature/3257 - Unassign transactions on report coverage change - #2294

Merged
toddlees merged 2 commits into
developfrom
feature/3257-1
Sep 15, 2026
Merged

toddlees merged 2 commits into
developfrom
feature/3257-1

Conversation

@sasha-dresden

@sasha-dresden sasha-dresden commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Issue FECFILE-3257

APP PR4342

  • Creates new endpoint /transactions/outside that will check a report for a given coverage range to see how many transactions will fall outside that range.
  • Adds new FLAG__ENABLE_UNASSIGNED_TRANSACTIONS and updates the existing unassigned transactions functions with it.

@danguyf danguyf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the new API endpoint successfully.

if transactions_outside_coverage_dates.exists():
if FLAG__ENABLE_UNASSIGNED_TRANSACTIONS:
transactions_outside_coverage_dates.delete()
if instance.can_unamend:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!!

)
if transactions_outside_coverage_dates.exists():
if FLAG__ENABLE_UNASSIGNED_TRANSACTIONS:
transactions_outside_coverage_dates.delete()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clean and simple

@toddlees toddlees left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@toddlees
toddlees merged commit 79a0a2d into develop Sep 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants