Skip to content

Feature/3257 - Unassign transactions on report coverage change - #4342

Merged
toddlees merged 6 commits into
developfrom
feature/3257-1
Sep 15, 2026
Merged

toddlees merged 6 commits into
developfrom
feature/3257-1

Conversation

@sasha-dresden

Copy link
Copy Markdown
Contributor

Issue FECFILE-3257

API PR2294

  • Moved Feature Flags into an Injection Token so we don't directly access the environment throughout our application and to clearly identify that these are feature flags as opposed to general environment configuration settings
  • Update name of unassigned transactions feature flag from showAllTransactionsPage to enableUnassignedTransactions as it is no longer specifically about showing/hiding that page.
  • Add Shared Form3 Service function getTransactionsOutsideCoverage which gets a count of the transactions that would be outside the coverage range
  • Update saving an edit Form3/Form3X to confirm with user before proceeding if any transactions fall outside the range.

@danguyf

danguyf commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

So far everything works in my local testing except the newly unassigned transactions are not showing up on the Transactions page. Am I doing it wrong?

@danguyf danguyf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working correctly for me.

I believe the final AC ("Then those transactions will be unassigned with that report and display in TRANSACTIONS.") is being implemented in FECFILE-1819 not here.

Merge conflicts to resolve.

<ul class="flex">
<li><a routerLink="/reports">Reports</a></li>
@if (showAllTransactionsPage) {
@if (enableUnassignedTransactions) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clarification!

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
77.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@toddlees
toddlees merged commit 12949e7 into develop Sep 15, 2026
4 of 5 checks passed
toddlees added a commit that referenced this pull request Sep 16, 2026
Revert "Merge pull request #4342 from fecgov/feature/3257-1"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants