Feature/3257 - Unassign transactions on report coverage change - #4342
Merged
Merged
Conversation
added 2 commits
September 9, 2026 08:31
…ersus general configuration
Contributor
|
So far everything works in my local testing except the newly unassigned transactions are not showing up on the Transactions page. Am I doing it wrong? |
danguyf
approved these changes
Sep 14, 2026
danguyf
left a comment
Contributor
There was a problem hiding this comment.
Everything is working correctly for me.
I believe the final AC ("Then those transactions will be unassigned with that report and display in TRANSACTIONS.") is being implemented in FECFILE-1819 not here.
Merge conflicts to resolve.
toddlees
reviewed
Sep 14, 2026
| <ul class="flex"> | ||
| <li><a routerLink="/reports">Reports</a></li> | ||
| @if (showAllTransactionsPage) { | ||
| @if (enableUnassignedTransactions) { |
sasha-dresden
force-pushed
the
feature/3257-1
branch
from
September 15, 2026 17:13
c13f879 to
79630b7
Compare
|
toddlees
approved these changes
Sep 15, 2026
toddlees
added a commit
that referenced
this pull request
Sep 16, 2026
Revert "Merge pull request #4342 from fecgov/feature/3257-1"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Issue FECFILE-3257
API PR2294
showAllTransactionsPagetoenableUnassignedTransactionsas it is no longer specifically about showing/hiding that page.getTransactionsOutsideCoveragewhich gets a count of the transactions that would be outside the coverage range