Repository navigation
Description
Automated weekly security sweep. Updated in place for W41 (this issue was originally opened for W40; it's being reused as the live tracker rather than opening a new W41 issue, per the sweep's "update existing open issue" rule). Note: issue #6 ("Security sweep — 2026-W39") is still open and now three weeks stale — recommend closing/merging it into this one manually.
Repo: fellwork/magna (default branch main, public, Rust workspace).
1. Alerts & settings — KNOWN GAP (informational)
Dependabot alerts, code-scanning alerts, secret-scanning alerts, security_and_analysis, branch-protection/ruleset detail, and Actions permissions settings were not checked this run — this session has no MCP tool for the GitHub REST endpoints those require (dependabot-alerts/code-scanning-alerts/secret-scanning-alerts list endpoints, repo security_and_analysis, rulesets/branch-protection, Actions permissions), and raw gh/curl use was explicitly out of scope for this run. Recommend a human spot-check the Security tab. (Prior-week runs reported a "main: PR + CI required" ruleset with required_approving_review_count: 0 via direct API access that this run's toolset does not have — not re-verified here; take that detail as unconfirmed this week.)
2. Dependency audit — cargo audit + cargo deny check (both run successfully this run)
cargo-audit/cargo-deny were not preinstalled; both installs initially hit the 180s/280s timeout on a busy shared build host but succeeded on retry with a longer budget. Results below are live, independently verified this run (not carried forward):
cargo audit — 4 vulnerabilities (errors) + 4 warnings, scanning 422 crate dependencies:
| Crate | Version | Advisory | Severity | Path | Fix |
|---|---|---|---|---|---|
quinn-proto |
0.11.14 | RUSTSEC-2026-0185 — remote memory exhaustion via unbounded out-of-order stream reassembly | High (7.5) | transitive, network stack (quic) | >=0.11.15 |
rsa |
0.9.10 | RUSTSEC-2023-0071 — Marvin Attack timing side-channel key recovery | Medium (5.9) | rsa ← jsonwebtoken ← magna-serv ← magna/magna-subscriptions — sits in the JWT verification (auth) path, not a dev-only tool |
No fixed upgrade available upstream |
rustls |
0.23.39 | RUSTSEC-2026-0285 (new 2026-09-14) — TLS 1.3 handshake messages accepted across encryption-level boundaries | Medium (5.3) | rustls ← {hyper-rustls,tokio-rustls} ← reqwest ← magna-remote, and rustls ← sqlx-postgres/sqlx-core ← sqlx ← magna/magna-build/magna-dataplan/magna-introspect/magna-serv/magna-subscriptions |
>=0.23.45 |
crossbeam-epoch |
0.9.18 | RUSTSEC-2026-0204 — invalid pointer deref in fmt::Pointer/Debug impl for Atomic/Shared |
Medium/unscored | crossbeam-epoch ← moka ← magna-introspect ← magna/magna-build/magna-dataplan |
>=0.9.20 |
Warnings (unsound/yanked, not blocking): anyhow 1.0.102 (RUSTSEC-2026-0190, unsound downcast_mut()), event-listener 5.4.1 (RUSTSEC-2026-0221, unsound !Send crossing), lru 0.16.4 (RUSTSEC-2026-0253, use-after-free panic-safety in pop()), spin 0.9.8 (yanked).
cargo deny check — fails outright, config error, not a pass/fail on advisories/licenses/bans: deny.toml uses four keys (unlicensed, copyleft, allow-osi-fsf-free, default under [licenses]) that current cargo-deny (0.20.2, the only version installable from crates.io today) rejects as removed (see EmbarkStudios/cargo-deny#611). This means the license/advisory governance gate this repo's own README/CLAUDE.md calls "fast" and implies is run is not actually runnable as configured, and it is not invoked anywhere in .github/workflows/ci.yml either — confirmed by reading the workflow file directly. Given magna's explicit license-durability commitment (never re-license from MIT/Apache-2.0) and public dual-license status, this is worth a deliberate decision (migrate deny.toml to the current schema, or pin an older cargo-deny in CI) rather than silent drift. Not fixed here — deny.toml is license-adjacent config, out of scope for this sweep's mechanical-fix allowlist. Low/informational, config-governance finding, not an advisory itself.
Cargo.lock has not changed since 2026-05-04 (predates even the W38 sweep), so these results are expected to hold until a dependency bump.
3. Workflows (.github/workflows/*.yml) — re-verified this run by reading both files directly
ci.yml: still missing a top-levelpermissions:block. Fix already proposed, unmerged, in PR chore(security): add top-level permissions blocks to workflows #7 (W38) and duplicated in PR Security sweep 2026-W40: add missing workflow permissions blocks #8 (W40) — both still open/draft. Actions pinned by tag, not SHA:actions/checkout@v4,Swatinem/rust-cache@v2. — Lowgqlmin-size.yml: still missing a top-levelpermissions:block (same unmerged fix in chore(security): add top-level permissions blocks to workflows #7/Security sweep 2026-W40: add missing workflow permissions blocks #8). Usesdtolnay/rust-toolchain@nightly— a floating/rolling channel ref, not a SHA or stable tag (higher drift risk than a normal version pin). Downloadsbinaryendirectly from its official GitHub releases over HTTPS — legitimate source, but unpinned to a checksum. — Lowactions/checkout@v4defaults topersist-credentials: true, and every job in both workflows triggers onpull_requestwithout overriding it. Public repo, neither workflow uses secrets, so practical exploitability is low — but it is a real hardening gap per the sweep's explicit check. Not one of the three allowed mechanical-fix types (pin-to-SHA / add-permissions / add-SECURITY.md), so reported only, not fixed. — Medium (hardening gap, not an active exposure)- No
pull_request_targetanywhere. No secrets passed to untrusted input. Norun:step interpolates${{ github.event.* }}.
4. Repo settings
SECURITY.mdpresent at root, points to a real disclosure contact (shane@fellwork.com) — good, unchanged, no action needed.
5. Code grep — no new findings
No hardcoded credentials (AKIA/ghp_/sk-/PEM), no tracked .env*, no wrangler.toml/fly.toml, no eval-equivalent risk (Rust workspace, N/A), no string-interpolated std::process::Command (no matches at all under crates/), no SQL migrations to check for SECURITY DEFINER/RLS (none in this repo — that's fellwork-data's domain). reqwest usage (crates/magna-remote/src/lib.rs) is a generic caller-supplied-URL HTTP client, not a hardcoded non-org endpoint — no finding. SQL query building (crates/magna-dataplan/src/steps/pg_*.rs) uses parameterized queries ($1, bound params) with quoted identifiers — no injection pattern found. Governance note (not a security finding): 104 .unwrap() calls remain in non-test library-crate code under crates/, which is a GOVERNANCE.md violation ("never .unwrap() in library code") — flagged for awareness only, per the sweep's own "spare attention" framing.
6. Severity summary
- Critical: none.
- High:
quinn-protoRUSTSEC-2026-0185 (remote memory exhaustion, CVSS 7.5) — live-verified this run. - Medium:
rsaMarvin Attack timing side-channel in the JWT verification path (no fix upstream);rustlsRUSTSEC-2026-0285 (TLS 1.3 handshake boundary bug);crossbeam-epochRUSTSEC-2026-0204; missingpermissions:blocks in both workflows (fix already proposed, unmerged, PR chore(security): add top-level permissions blocks to workflows #7/Security sweep 2026-W40: add missing workflow permissions blocks #8);persist-credentialsdefault-true onpull_request-triggered jobs (both workflows). - Low: tag-pinned (not SHA-pinned) actions including the floating
dtolnay/rust-toolchain@nightly; unpinnedbinaryendownload;anyhow/event-listener/lruunsound-warnings;spinyanked warning;cargo deny checkconfig-schema drift (gate is non-functional as configured and not run in CI); 104.unwrap()calls in library code (governance note, not a vulnerability). - Informational: KNOWN GAP — Dependabot/code-scanning/secret-scanning alert dashboards and repo security settings (branch protection ruleset, Actions permissions,
security_and_analysis) not checkable via this session's approved tools (mcp__github__*only, nogh/raw REST). Recommend a human spot-check the Security tab.
PR
No new PR opened this run. PRs #7 (claude/magna-security-2026-W38, draft, open) and #8 (claude/magna-security-2026-W40, draft, open) already contain the exact trivial fix this run would otherwise propose (top-level permissions: contents: read for ci.yml/gqlmin-size.yml), and both remain unmerged. Opening a third duplicate was judged net-negative (more unmerged noise, zero additional coverage) rather than useful — recommend merging #8 (supersedes #7) and closing #7, then revisiting action-SHA-pinning and the deny.toml schema drift as separate follow-ups.
Activity
srmcguirt commentedon Oct 1, 2026
Daily maintenance pass (2026-10-01): no new PR opened.
permissions:block inci.yml/gqlmin-size.yml) is already covered by open draft PR Security sweep 2026-W40: add missing workflow permissions blocks #8 (and duplicately by chore(security): add top-level permissions blocks to workflows #7) — opening another would just be a third copy of the same diff.dtolnay/rust-toolchain@nightlyref, and actually wiringcargo audit/cargo denyinto CI) are either policy calls for @srmcguirt or require editing.github/workflows/*, which this daily routine is not permitted to touch.No code change needed from this routine today; flagging for manual follow-up on the policy/CI-wiring items.
Generated by Claude Code
srmcguirt commentedon Oct 2, 2026
needs-spec: per the routine's own follow-up comment, the open items here (branch-protection policy, action SHA-pinning, wiring
cargo audit/cargo denyinto CI) are maintainer policy calls or workflow edits the daily routine isn't permitted to make — not yet a spec'd code task.Generated by Claude Code
[-]Security sweep — 2026-W40[/-][+]Security sweep — 2026-W41[/+]srmcguirt commentedon Oct 5, 2026
W41 delta vs. W40:
New / changed:
cargo auditandcargo denywere successfully installed and run live this time (W40's run skipped both — install timed out). Results: identical advisory set to what W40 reported from memory/estimate would apply (Cargo.lockunchanged since 2026-05-04), now independently confirmed:quinn-protoRUSTSEC-2026-0185 (High 7.5),rsaRUSTSEC-2023-0071 (Medium, JWT path, no fix available),rustlsRUSTSEC-2026-0285 (Medium, new as of 2026-09-14),crossbeam-epochRUSTSEC-2026-0204 (Medium/unscored), plus 4 unsound/yanked warnings (anyhow,event-listener,lru,spin).cargo deny checkcannot actually run against currentcargo-deny(0.20.2) —deny.tomluses config keys removed in a pastcargo-denyschema migration (PR #611). The license/advisory governance gate is non-functional as configured and isn't wired intoci.ymleither. Flagged as a config-drift/governance finding, not a vulnerability. Not fixed (license-adjacent file, judged out of scope for a mechanical PR).Unchanged (re-verified):
ci.yml/gqlmin-size.ymlstill missing top-levelpermissions:blocks — PRs chore(security): add top-level permissions blocks to workflows #7 and Security sweep 2026-W40: add missing workflow permissions blocks #8 both still open/unmerged and both already fix this.persist-credentials: truedefault onpull_request-triggered checkouts in both workflows — still present, still low-impact (no secrets in these workflows), still not mechanically fixable per policy.dtolnay/rust-toolchain@nightly— unchanged.SECURITY.mdpresent and correct — no action needed..unwrap()calls in library crates — governance note, not re-counted exactly but order-of-magnitude consistent with prior runs.Resolved: none this week.
PR: no new PR opened — #7/#8 already cover the only mechanical fix available. Recommend merging #8 and closing #7 to stop the duplication, same recommendation as last week.
Known gap (repeated): Dependabot/code-scanning/secret-scanning alerts and repo security settings (branch protection, Actions permissions,
security_and_analysis) were not checked this run — no MCP tool available for those GitHub REST endpoints in this session, andgh/rawcurlwere out of scope. Recommend a human spot-check the Security tab.Generated by Claude Code