Skip to content

Security sweep — 2026-W46 #11

Open

Description

@srmcguirt

Weekly automated security sweep.

Severity: high.

  • cargo audit (422 crates): two RUSTSEC advisories at 7.5/high in quinn-proto (reachability unconfirmed — cargo tree -i found no resolvable path, likely an inactive lockfile entry; lockfile-hygiene candidate). Confirmed-reachable medium-severity CVEs through widely-used runtime crates: rsa (Marvin timing attack, via jsonwebtoken→magna-serv/magna-subscriptions), rustls family + rustls-webpki + webpki-roots (via reqwest→magna-remote and sqlx→most of the workspace), crossbeam-epoch (via moka), crypto-bigint (via jsonwebtoken's EC chain). No dependency bump drafted per sweep scope — upstream patch versions exist for all of these.
  • ci.yml/gqlmin-size.yml had no top-level permissions: block; actions referenced by tag (actions/checkout@v4 ×4, Swatinem/rust-cache@v2 ×3) or branch ref (dtolnay/rust-toolchain@nightly).
  • gqlmin-size.yml downloads a binaryen release tarball over HTTPS with no checksum verification (minor supply-chain gap, not in the three mechanical-fix categories).

Fixed in PR #12 (draft): adds permissions blocks, SHA-pins checkout/rust-cache/rust-toolchain (all live-verified against upstream — note two SHAs the investigating agent proposed for wrangler-action-style refs did NOT match any real tag and were discarded in favor of independently verified values). SECURITY.md already present, no change needed.

Code-quality note (non-security, per magna's own conventions): .unwrap() found 104× across 18 library-crate files — spot-check suggests many are in test code, but a full triage is recommended before treating this as 104 real violations of "never .unwrap() in library code."

Alerts: Dependabot/code-scanning 403 (scope gap, inconclusive). Secret scanning/actions/permissions blocked by proxy.

Settings: Branch ruleset does enforce required_status_checks (clippy/fmt/publish-dry-run/test) — better gated than mail/kindly-note — but required_approving_review_count: 0.

This issue consolidates the prior open sweep issues (#10, #9, #6), which are being closed as duplicates of this one.

Activity

  1. changed the title [-]Security sweep — 2026-W43[/-] [+]Security sweep — 2026-W44[/+] on Oct 26, 2026
  2. srmcguirt commented on Oct 26, 2026

    @srmcguirt
    MemberAuthor

    Delta vs. 2026-W43: cargo audit now runs cleanly (cargo-audit available this run) — 14 vulns/5 warnings, highest still 7.5 high, no critical. Workflow/code findings unchanged. No new mechanical PR opened — #8/#7 already cover ci.yml/gqlmin-size.yml permissions and remain unmerged after 6+ weeks, please merge #8 and close #7.

    Housekeeping note: this issue has 2 older open duplicates (#10 W42, #9 W41) from before the "update, don't recreate" process was enforced. Not closed by this run per the standing instruction not to close duplicates unilaterally — flagging for a human to close.


    Generated by Claude Code

  3. srmcguirt commented on Oct 30, 2026

    @srmcguirt
    MemberAuthor

    needs-spec: this is a sweep report, not a scoped task — the only concrete action named (merge PR #8 / close PR #7) is a human PR-management decision, not something with coded acceptance criteria for an agent to execute.


    Generated by Claude Code

  4. changed the title [-]Security sweep — 2026-W44[/-] [+]Security sweep — 2026-W45[/+] on Nov 2, 2026
  5. srmcguirt commented on Nov 2, 2026

    @srmcguirt
    MemberAuthor

    2026-W45 delta vs W44: cargo-audit was available last week and is not this week — install attempt timed out at the 90s cap, and Dependabot alerts (the fallback) returned an inconclusive 403 rather than real data, so this run has zero dependency-advisory visibility, upgraded from a medium to a high finding until re-confirmed. All other findings (missing permissions: blocks, dtolnay/rust-toolchain@nightly, unchecksummed binaryen download, ruleset present with real required-status-checks but 0 required reviews) are unchanged from W44. PRs #7/#8 remain open and unmerged (7+ weeks) — still recommend merging #8 and closing #7 rather than opening a fourth duplicate.


    Generated by Claude Code

  6. changed the title [-]Security sweep — 2026-W45[/-] [+]Security sweep — 2026-W46[/+] on Nov 9, 2026
  7. marked Security sweep — 2026-W42 #10 as a duplicate of this issue on Nov 9, 2026
  8. marked Security sweep — 2026-W41 #9 as a duplicate of this issue on Nov 9, 2026
  9. marked Security sweep — 2026-W39 #6 as a duplicate of this issue on Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions