tests: fail the percpu instance by its id, prove the dispatch reaches the receiving CPU - #764
Merged
Merged
Conversation
This was referenced Sep 2, 2026
The failing script counted its runs in _ENV, and the plain run at the end of the test left the counter at 1: on the next run of the suite the error fired on the first instance, so the rollback assertion covered the rollback of nothing. Keying the failure on lunatik.cpu() == 1 needs no state, and the plain run passes because a plain runtime has no id. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lneto
force-pushed
the
claude_percpu_tests
branch
from
September 3, 2026 12:46
0721b6f to
0fe50fe
Compare
The drop case shows a percpu script is dispatched, not which instance takes the packet: a dispatch that always picked instance 0 would pass it. Pin the ping to the last online CPU, where the veth runs the receive softirq, and check the callback reports that CPU as its instance id and no other. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwNvkpyMhVjn5B8pJBViW5
lneto
force-pushed
the
claude_percpu_tests
branch
from
September 3, 2026 14:23
0fe50fe to
5dd79a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests that stand on their own against master, split out of #762.
tests/runtime/percpu_failcounted its runs in_ENV, and the plain run at the end of the test left the counter at 1: on the next run of the suite the error fired on the first instance, so the rollback assertion covered the rollback of nothing. Keying the failure onlunatik.cpu() == 1needs no state, and the plain run passes because a plain runtime has no id.tests/xdpgains a case proving the callback of a percpu script runs on the instance of the receiving CPU. The drop case shows a percpu script is dispatched, not which instance takes the packet: a dispatch that always picked instance 0 would pass it. The ping is pinned to the last online CPU, where the veth runs the receive softirq, and the callback must report that CPU as its instance id and no other; only ICMPv4 counts, since the namespace emits IPv6 autoconf traffic from a context the test does not pin. Skipped on a single CPU. Validated by pinning the dispatch to instance 0 and watching it fail.Tested on 6.8.0-136 (aarch64): runtime 17/17, xdp 6/6, clean dmesg.
🤖 Generated with Claude Code