Skip to content

Add licenses.yml entries for the ten schemes from #885 - #889

Merged
mbadolato merged 1 commit into
mbadolato:masterfrom
zaccesss:add-licenses-for-885
Oct 28, 2026
Merged

mbadolato merged 1 commit into
mbadolato:masterfrom
zaccesss:add-licenses-for-885

Conversation

@zaccesss

Copy link
Copy Markdown
Contributor

The daily sync in #885 added ten schemes without licenses.yml entries, so Check Scheme Licenses has failed on master since then.

Each of them is listed on terminalthemes.com as MIT and redistributable, with you as the verified author. This adds them as MIT with the theme's page as the source:

  • Analog Heartbeat
  • Analog Heartbeat: Phosphor
  • Hadal Bloom
  • Moss & Ember
  • Neon Raincheck
  • Neon Raincheck: After Hours
  • Paper Crane
  • Paper Crane: Midnight Ink
  • Sonoran Afterglow
  • Sonoran Blue Hour

The entries sit in alphabetical order with the other schemes. python tools/check_licenses.py passes and all eight tests in tools/test_check_licenses.py pass locally.

If it would help, the daily sync could write these entries itself whenever terminalthemes.com lists a licence. I am happy to look at that in a separate PR.

@mbadolato
mbadolato merged commit b344e7f into mbadolato:master Oct 28, 2026
1 check passed
@mbadolato

Copy link
Copy Markdown
Owner

Ugh, thanks! I'll ahve to see what that isn't coming over

@mbadolato

mbadolato commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

@zaccesss, if you have a moment, can you just give me a quick summary of what I need to change the sync script to do? Is it just adding to the licenses YAML file, or does something else need to happen too? The sync is from the TT side so not accessible in this repo

@zaccesss

zaccesss commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

@mbadolato Yes, it is only licenses.yml. For each scheme the sync adds, renames or removes:

  1. Add an entry keyed by the scheme's display name (the file name in schemes/ without the extension or the name: of a YAML source in yaml/).
  2. Give it two keys: license (an SPDX identifier such as MIT, unknown when terminalthemes.com lists no licence) and source (the theme's terminalthemes.com page, "" if there is none).
  3. Rename or remove the entry when the sync renames or removes a scheme, because check_licenses.py also fails on an entry with no matching scheme.

Keeping the file in alphabetical order is tidy but the check does not require it. Running python tools/check_licenses.py after the sync shows anything it missed.

I was happy to open a PR to make this easier, so I have: #892 (for #891) adds tools/set_license.py, which the sync can call once per theme, for example python3 tools/set_license.py set "Paper Crane" --license MIT --source https://terminalthemes.com/themes/paper-crane. It keeps the header and alphabetical order and leaves every other entry untouched. Have a look in full whenever you have time and let me know if you would like anything changed.

@zaccesss

Copy link
Copy Markdown
Contributor Author

@mbadolato the summary is in my comment above and #892 adds a helper the sync can call.

@mbadolato

Copy link
Copy Markdown
Owner

@zaccesss Fantastic, thank you! I have Cursor reading this thread and the links and implementing it for inbound and outbound to/from TT

@zaccesss
zaccesss deleted the add-licenses-for-885 branch October 29, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants