Repository navigation
test: skip Core conformance when verdict-core is not installed - #19
Merged
Merged
Conversation
mrnicholasbcarter-code
deleted the
fix/core-conformance-importorskip
branch
September 24, 2026 10:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh clone following the normal setup (
uv sync --extra dev && uv run pytest) fails at collection:The conformance test imports
verdict(verdict-core) at module level. verdict-core is not a declared dependency; CI installs it separately at a pinned SHA. So any local contributor, or an interviewer cloning the repo, sees a red test run.Fix:
pytest.importorskip("verdict.provider_receipts"). verdict-backtest'stests/test_core_conformance.pyalready uses this pattern. Coverage in CI is unchanged, because CI still installs the pinned Core and runs these tests.Verified:
verdict-core@55880def…:tests/test_core_conformance.py→ 2 passed.ruff checkandruff format --checkpass (ruff 0.16.8, the version CI currently resolves).