Skip to content

Preserve actuator delay state across partial resets - #1218

Open
lukehugh wants to merge 1 commit into
mujocolab:mainfrom
lukehugh:codex/fix-actuator-delay-partial-reset
Open

lukehugh wants to merge 1 commit into
mujocolab:mainfrom
lukehugh:codex/fix-actuator-delay-partial-reset

Conversation

@lukehugh

@lukehugh lukehugh commented Oct 6, 2026

Copy link
Copy Markdown

Partial resets recomputed actuator controls for the whole batch, advancing delay histories and changing controls in environments whose physics had not advanced. Scope reset-time writes and history backfills to the reset environments, including learned actuator histories, while keeping one delay update per physics substep. Regression tests cover explicit and automatic resets, initialization, unchanged trajectories, and builtin/fused control paths. Validated with make check and CPU make test (1094 passed, 13 skipped).

Fixes #1216

Scope reset-time control writes and history backfills to the reset environments, preserving other environments' delay buffers, lag schedules, and controls. Cover explicit and automatic resets, initialization, and builtin, fused, and learned actuator paths.

Fixes mujocolab#1216
Copilot AI balanced review requested due to automatic review settings October 6, 2026 09:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Partial reset advances actuator delay buffers in environments that were not reset

2 participants