Repository navigation
Fix six reported bugs: bar toggle, hibernation, weather, VM mounts, keybindings menu, group binds - #12155
Open
merkhanov wants to merge 6 commits into
Open
Fix six reported bugs: bar toggle, hibernation, weather, VM mounts, keybindings menu, group binds#12155merkhanov wants to merge 6 commits into
merkhanov wants to merge 6 commits into
Conversation
on hid the bar and off showed it, backwards from what a user calling `omarchy toggle bar on/off` expects. The bug lived in the raw passthrough to the bar-off flag (`omarchy-toggle bar-off "$1"`), so the fix maps on/off explicitly instead of forwarding the argument as-is. omarchy-toggle-fullscreen-desktop called omarchy-toggle-bar with its own on/off (fullscreen state, not bar state) and relied on the old inverted semantics to hide the bar on "on"; it now maps that call explicitly too so entering/leaving full screen still hides/shows the bar correctly. Fixes omacom#12082
setup writes /etc/limine-entry-tool.d/resume.conf (and rtc-alarm.conf on s2idle systems) with resume= kernel parameters, but remove only deleted the mkinitcpio hook. The rebuilt UKI kept pointing at a swapfile that no longer existed. remove now deletes both drop-ins before regenerating the initramfs, symmetric with what setup creates. Fixes omacom#12096
wttr.in's auto-detect (?format=%l) usually answers "City, Country", which the script truncated at the first comma to get the city. For some IPs it instead answers bare "lat,lon" coordinates, and the same truncation chopped that at its own comma too, leaving a bare latitude that wttr.in rejects as a location query -- surfacing as "Weather unavailable" with no location set. Only truncate at the comma when the response isn't itself a coordinate pair. Fixes omacom#12127
…id bit The dockurr/windows container sets its bind-mounted storage/shared folders to mode 2777 (setgid + world-writable) on every boot. Per chmod(1), a plain numeric mode like "0700" preserves a directory's existing setgid bit unless given a leading zero, minus, or equals form -- so the existing "chmod 0700" calls silently left the directories at 2700. mounted_leaf_matches() and prepare_user_mount_sources() both compare against an exact mode of 700, so every launch after the VM's first boot failed permanently until the bit was cleared by hand. Use the "00700" form (and add a regression test simulating the container's 2777 mutation) so the existing hardening actually clears the bit. Fixes omacom#12134
…etter
omarchy-menu-keybindings re-executes the user's hyprland.lua under a stub hl
object to recover descriptions for binds Hyprland reports as dispatcher
__lua. The stub's fallback answers every undefined member with a `noop`
object whose __index metamethod always returns itself -- including for
numeric keys. A config that runs a completely valid pattern inside the real
compositor, e.g. `for _, w in ipairs(hl.get_windows() or {}) do`, calls
ipairs on that noop object; since t[i] never returns nil, ipairs never
terminates, hanging the menu (and leaking an unreaped 100%-CPU lua process
per keypress).
Make noop's __index return nil for numeric keys so ipairs terminates
immediately, while still returning noop for string keys so a chained call
like hl.get_windows().active remains a harmless no-op.
Fixes omacom#12124, omacom#12052
…index The default group-window bindings register indices 1-5 unconditionally against hl.dsp.group.active(...). Hyprland rejects an index past the group's actual window count, but Omarchy surfaces that rejection as a "Runtime error in lua: Index out of range" notification instead of doing nothing. A native dispatcher object gives the config no way to guard the rejection, since no Lua runs again at keypress time -- only a Lua function dispatcher does. Switch to one and pcall the dispatch so a miss is silently a no-op, matching Hyprland's own behavior for a genuinely out-of-range group index. Fixes omacom#12085
This was referenced Sep 28, 2026
This was referenced Sep 28, 2026
Collaborator
|
Thanks for working through these. I reviewed all six commits against Competing fixes. Five of the six bugs already have open pull requests that fix only that bug, and #12127's fix is already verified in #12138, which makes the same change to
Defects found in this pull request:
What checked out: Next: this waits on the maintainer to choose between this bundle and the per-bug pull requests. The group-window fix, which nothing else covers, would be easiest to land as its own pull request, with the menu and notification problems above addressed. |
1 task
Collaborator
|
Following the merge of #12323, Only the Windows setgid part of this six-fix bundle is covered by the merged PR. Keep the unrelated bar, hibernation, weather, keybindings and group-window fixes open; remove the duplicate Windows changes. Scope checked by GPT-6 in Codex and Codex Medium against the discussion and landed change; review independence is not guaranteed. No tests were rerun for this cleanup. Omabot on behalf of DHH |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Six independent, atomic fixes for currently-open issues, each verified with a test that fails without the fix and passes with it:
omarchy-toggle-bar on/offarguments were inverted (onhid the bar). Fixed the passthrough and the one caller (omarchy-toggle-fullscreen-desktop) that relied on the old inverted semantics.omarchy-hibernation-removenever deleted the Limineresume.conf/rtc-alarm.confdrop-ins thatomarchy-hibernation-setupcreates, leaving a rebuilt UKI pointing at a swapfile that no longer exists.omarchy-weather-locationauto-detect truncated wttr.in's barelat,loncoordinate responses at their own comma, leaving an invalid bare latitude and "Weather unavailable".omarchy-windows-vm'schmod 0700(missing the leading zero) silently left a setgid bit the dockurr/windows container sets on every boot, permanently failing the exact-mode check on every launch after the first.omarchy-menu-keybindings's Lua sandbox stub'snoopfallback answered every key, including numeric ones, soipairs()over an unstubbed getter (valid inside the real compositor) never terminated, hanging the keybindings menu and leaking a 100%-CPUluaprocess per keypress.Super+Alt+<number>group-window bindings surfaced Hyprland's "index out of range" rejection as a Lua runtime error notification instead of doing nothing.Test plan
./test/cli— passes./test/shell— passes (full suite, no regressions)bin/omarchy-menu-keybindings's fix additionally verified against the issue's exact literal reproduction (ipairs(hl.get_windows() or {})in a fakehyprland.lua), which hangs (timeoutexit 124) before the fix and returns immediately afterdefault/hypr/bindings/tiling.lua's fix verified against the documented Hyprland Lua API (hl.bindaccepting a function dispatcher,hl.dispatchfor imperative dispatch) since no compositor is available in this environment to exercise it live