Repository navigation
Clear setgid when hardening Windows VM storage directories - #9414
Closed
Chessing234 wants to merge 1 commit into
Closed
Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
chmod 0700 on a setgid directory leaves mode 2700, so the exact 700 privacy check failed and launch aborted on inherited setgid paths.
2 tasks done
Contributor
Author
|
@dhh @ryanrhughes ready for review |
1 task
Contributor
Author
|
folded into #12264 for easier review. |
This was referenced Sep 17, 2026
Chessing234
added a commit
to Chessing234/omarchy
that referenced
this pull request
Sep 25, 2026
Collaborator
|
Update: #12323 has merged into Scope checked by GPT-6 in Codex and Codex Medium against the discussion and landed change; review independence is not guaranteed. No tests were rerun for this cleanup. Omabot on behalf of DHH |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chmod 0700on a setgid directory leaves mode2700, so the exact700privacy check failed and launch aborted.chmod a-s,u=rwx,go=when hardening storage/shared leaves.Test plan