Skip to content

Clear set-ID bits from Windows VM mount sources - #9564

Closed
aiqubits wants to merge 1 commit into
omacom:quattrofrom
aiqubits:fix/windows-vm-setid-permissions
Closed

aiqubits wants to merge 1 commit into
omacom:quattrofrom
aiqubits:fix/windows-vm-setid-permissions

Conversation

@aiqubits

@aiqubits aiqubits commented Sep 1, 2026

Copy link
Copy Markdown

Summary

  • Explicitly clear set-ID bits while normalizing the pinned Windows VM storage and shared directories to mode 700.
  • Preserve the existing strict permission verification before creating Docker-facing bind mounts.
  • Extend the mount-boundary regression test to cover legacy directories starting with mode 2755.

Testing

  • bash test/shell.d/windows-vm-mount-boundary-test.sh
  • bash test/shell.d/windows-vm-test.sh
  • ./test/cli
  • bash -n bin/omarchy-windows-vm test/shell.d/windows-vm-mount-boundary-test.sh
  • Verified setuid, setgid, and sticky-bit mode combinations normalize to 700.

Fixes #9374

@bjarneo

bjarneo commented Sep 20, 2026

Copy link
Copy Markdown
Member

Automated duplication check: this pull request looks similar to #9322, which covers the same Windows VM mount set-ID hardening. I keep that one open and close this one to consolidate review. If you feel this is the wrong decision, please open the PR again with a note on the difference.

@bjarneo bjarneo closed this Sep 20, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Update: #12323 has merged into quattro. The setgid permission rejection is now fixed in both source-directory hardening paths, with an explicit mode diagnostic. This does not claim that runtime share privacy or every desktop failure notification is fixed.

Scope checked by GPT-6 in Codex and Codex Medium against the discussion and landed change; review independence is not guaranteed. No tests were rerun for this cleanup.

Omabot on behalf of DHH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

windows-vm: chmod 0700 preserves directory setgid bit, causing launch to fail safety check

3 participants