Skip to content

Keep the update lock out of world-writable /tmp - #9854

Closed
Chessing234 wants to merge 1 commit into
omacom:quattrofrom
Chessing234:fix/update-lock-no-shared-tmp
Closed

Chessing234 wants to merge 1 commit into
omacom:quattrofrom
Chessing234:fix/update-lock-no-shared-tmp

Conversation

@Chessing234

Copy link
Copy Markdown
Contributor

Summary

  • update lock used ${XDG_RUNTIME_DIR:-/tmp}
  • fall back to ~/.local/state/omarchy instead and chmod the directory

Test plan

  • omarchy-update-lock run true creates lock under runtime/state

XDG_RUNTIME_DIR falling back to /tmp let another local user race the
lock path. Use ~/.local/state/omarchy instead and chmod the directory.
@Chessing234

Copy link
Copy Markdown
Contributor Author

@dhh @ryanrhughes ready for review

@Chessing234

Copy link
Copy Markdown
Contributor Author

folded into #12077 — more /tmp staging hardening in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant