Repository navigation
Keep update log, lock, reminders, and clipboard shares out of shared /tmp - #12077
Closed
Chessing234 wants to merge 6 commits into
Closed
Chessing234 wants to merge 6 commits into
Chessing234 wants to merge 6 commits into
Conversation
A pre-created /tmp/omarchy-update.log symlink let another local user redirect script(1) into the victim's files. Stage the log under XDG_RUNTIME_DIR (or a 0700 cache under \$HOME).
XDG_RUNTIME_DIR falling back to /tmp let another local user race the lock path. Use ~/.local/state/omarchy instead and chmod the directory.
Falling back to /tmp/omarchy-reminders left reminder bodies world-readable on multi-user hosts. Prefer XDG_RUNTIME_DIR, else ~/.local/state, and chmod the directory 0700.
Clipboard mode wrote wl-paste into a world-readable mktemp under /tmp and left it forever. Stage under XDG_RUNTIME_DIR (else ~/.local/state), chmod 0600, wait for LocalSend, then remove the temp file.
This was referenced Sep 16, 2026
Contributor
Author
|
folding into #12109 with the other /tmp path hardening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tmp.Combines #9084, #9854, #9852, and #9862 into one reviewable PR.
Test plan
bash test/shell.d/update-log-path-test.sh~/.local/state/omarchy(or equivalent) instead of shared/tmp/tmp