Repository navigation
[Security] Keep the update transcript out of world-writable /tmp - #9084
Closed
Chessing234 wants to merge 3 commits into
Closed
Chessing234 wants to merge 3 commits into
Chessing234 wants to merge 3 commits into
Conversation
A pre-created /tmp/omarchy-update.log symlink let another local user redirect script(1) into the victim's files. Stage the log under XDG_RUNTIME_DIR (or a 0700 cache under \$HOME).
Contributor
Author
|
@dhh @ryanrhughes ready for review |
1 of 3 tasks
1 of 2 tasks
1 of 5 tasks
Contributor
Author
|
folded into #12077 — more /tmp staging hardening in one place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omarchy updatealways wrote/tmp/omarchy-update.logscript(1)into the victim's files$XDG_RUNTIME_DIR/omarchy-update/(or a 0700 cache under~/.cache/omarchy/update); analyze-logs follows the same path and refuses symlinksTest plan
bash test/shell.d/update-log-path-test.shomarchy update -y(or a dry path) and confirm the transcript is not under/tmp/omarchy-update.log