Skip to content

[ExecuTorch][WebGPU] Op-tests for clamp + hardtanh#21157

Merged
meta-codesync[bot] merged 2 commits into
gh/JCNTH/117/basefrom
gh/JCNTH/117/head
Jul 24, 2026
Merged

[ExecuTorch][WebGPU] Op-tests for clamp + hardtanh#21157
meta-codesync[bot] merged 2 commits into
gh/JCNTH/117/basefrom
gh/JCNTH/117/head

Conversation

@JCNTH

@JCNTH JCNTH commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Adds the op-test suites for the clamp-family ops ported in the diff below. clamp covers both-bounds and a min=None case (exercising the None -> -inf substitution); hardtanh covers the default (-1, 1) bounds and a wider (-2, 2).

Key changes:

  • test/ops/test_unary_activations.pyClampModule, HardtanhModule, CLAMP_CONFIGS, HARDTANH_CONFIGS.
  • test/op_tests/cases.py_clamp_suite + _hardtanh_suite.
    @exported-using-ghexport

Differential Revision: D112257631

Differential Revision: D112257631

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21157

Note: Links to docs will display an error until the docs builds have been completed.

❌ 46 New Failures, 2 Unrelated Failures

As of commit 2057da8 with merge base 4a26c64 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

  • pull / unittest / windows / windows-job (gh) (matched win rule in flaky-rules.json)
    Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under 'C:\actions-runner\_work\executorch\executorch\test-infra\.github\actions\teardown-windows'. Did you forget to run actions/checkout before running your local action?
  • pull / unittest-editable / windows / windows-job (gh) (matched win rule in flaky-rules.json)
    Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under 'C:\actions-runner\_work\executorch\executorch\test-infra\.github\actions\teardown-windows'. Did you forget to run actions/checkout before running your local action?

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2026
This was referenced Jul 22, 2026

@psiddh psiddh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving full WebGPU stack

[ghstack-poisoned]
@meta-codesync
meta-codesync Bot merged commit fa94b73 into gh/JCNTH/117/base Jul 24, 2026
141 of 193 checks passed
@meta-codesync
meta-codesync Bot deleted the gh/JCNTH/117/head branch July 24, 2026 07:05
@meta-codesync
meta-codesync Bot temporarily deployed to cherry-pick-bot July 24, 2026 07:05 Inactive
JCNTH added a commit that referenced this pull request Jul 24, 2026
Pull Request resolved: #21157

Adds the op-test suites for the clamp-family ops ported in the diff below. `clamp` covers both-bounds and a `min=None` case (exercising the `None -> -inf` substitution); `hardtanh` covers the default `(-1, 1)` bounds and a wider `(-2, 2)`.

Key changes:
- `test/ops/test_unary_activations.py` — `ClampModule`, `HardtanhModule`, `CLAMP_CONFIGS`, `HARDTANH_CONFIGS`.
- `test/op_tests/cases.py` — `_clamp_suite` + `_hardtanh_suite`.
ghstack-source-id: 406360836
@exported-using-ghexport

Differential Revision: [D112257631](https://our.internmc.facebook.com/intern/diff/D112257631/)
JCNTH added a commit that referenced this pull request Jul 24, 2026
Pull Request resolved: #21157

Adds the op-test suites for the clamp-family ops ported in the diff below. `clamp` covers both-bounds and a `min=None` case (exercising the `None -> -inf` substitution); `hardtanh` covers the default `(-1, 1)` bounds and a wider `(-2, 2)`.

Key changes:
- `test/ops/test_unary_activations.py` — `ClampModule`, `HardtanhModule`, `CLAMP_CONFIGS`, `HARDTANH_CONFIGS`.
- `test/op_tests/cases.py` — `_clamp_suite` + `_hardtanh_suite`.
ghstack-source-id: 406360836
@exported-using-ghexport

Differential Revision: [D112257631](https://our.internmc.facebook.com/intern/diff/D112257631/)
JCNTH added a commit that referenced this pull request Jul 24, 2026
Pull Request resolved: #21157

Adds the op-test suites for the clamp-family ops ported in the diff below. `clamp` covers both-bounds and a `min=None` case (exercising the `None -> -inf` substitution); `hardtanh` covers the default `(-1, 1)` bounds and a wider `(-2, 2)`.

Key changes:
- `test/ops/test_unary_activations.py` — `ClampModule`, `HardtanhModule`, `CLAMP_CONFIGS`, `HARDTANH_CONFIGS`.
- `test/op_tests/cases.py` — `_clamp_suite` + `_hardtanh_suite`.
ghstack-source-id: 406360836
@exported-using-ghexport

Differential Revision: [D112257631](https://our.internmc.facebook.com/intern/diff/D112257631/)
JCNTH added a commit that referenced this pull request Jul 24, 2026
Pull Request resolved: #21157

Adds the op-test suites for the clamp-family ops ported in the diff below. `clamp` covers both-bounds and a `min=None` case (exercising the `None -> -inf` substitution); `hardtanh` covers the default `(-1, 1)` bounds and a wider `(-2, 2)`.

Key changes:
- `test/ops/test_unary_activations.py` — `ClampModule`, `HardtanhModule`, `CLAMP_CONFIGS`, `HARDTANH_CONFIGS`.
- `test/op_tests/cases.py` — `_clamp_suite` + `_hardtanh_suite`.
ghstack-source-id: 406360836
@exported-using-ghexport

Differential Revision: [D112257631](https://our.internmc.facebook.com/intern/diff/D112257631/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants