Skip to content

[ExecuTorch][WebGPU] Port repeat#21168

Open
JCNTH wants to merge 2 commits into
gh/JCNTH/128/basefrom
gh/JCNTH/128/head
Open

[ExecuTorch][WebGPU] Port repeat#21168
JCNTH wants to merge 2 commits into
gh/JCNTH/128/basefrom
gh/JCNTH/128/head

Conversation

@JCNTH

@JCNTH JCNTH commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Ports aten.repeat.default as a per-element tiling gather, mirroring the landed permute/flip index-transform (dual-TensorMeta, 2D-fold dispatch). repeat is pure data movement, so it maps each output element to its source via a per-dim modulo and copies — no fp compute.

Key changes:

  • runtime/ops/repeat/{Repeat.cpp, repeat.wgsl} (+ generated repeat_wgsl.h) — per out flat idx: unravel via out_meta.strides, in_coord = out_coord % in_meta.sizes[in_d], ravel via in_meta.strides, output[out] = input[in]; registered aten.repeat.default.
  • CMakeLists.txtruntime/ops/repeat/Repeat.cpp in WEBGPU_SRCS.

Mirrors Vulkan glsl/repeat_buffer.glsl (in_tidx[d] = out_tidx[d] % size_at(in_meta, d)). Vulkan's innermost-first BufferMetadata auto-aligns a shorter input; WebGPU's NCHW TensorMeta makes the right-alignment explicit via offset = out_ndim - in_ndim (leading d < offset dims are pure prepends, contributing 0). No repeats-arg read needed: the repeated out dims are baked in by export, so the tiling is recoverable from shapes alone. No int dtype-guard (bit-preserving movement, like flip); the nbytes != numel*4 guard rejects int64/fp16.
@exported-using-ghexport

Differential Revision: D112257679

Differential Revision: D112257679

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21168

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures, 17 Pending, 11 Unrelated Failures

As of commit 21dc925 with merge base 4a26c64 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2026
This was referenced Jul 22, 2026
This was referenced Jul 22, 2026
@JCNTH
JCNTH requested a review from psiddh July 23, 2026 02:09

@psiddh psiddh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving full WebGPU stack

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants