Skip to content

CHI-3945: Tweak styles for QA feedback - #4660

Merged
stephenhand merged 3 commits into
masterfrom
CHI-3945-ui_fixes
Sep 4, 2026
Merged

stephenhand merged 3 commits into
masterfrom
CHI-3945-ui_fixes

Conversation

@stephenhand

Copy link
Copy Markdown
Collaborator

Description

  • Remove button icons on voicemail task panel
  • Tweak spacing on voicemail task panel

Checklist

  • Corresponding issue has been opened
  • [n/a] New tests added
  • [n/a] Feature flags added
  • [n/a] Strings are localized
  • [n/a] Tested for chat contacts
  • Tested for call contacts

Other Related Issues

None

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

Copilot AI lite review requested due to automatic review settings September 3, 2026 16:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The icon removal left behind empty spacer elements in the action buttons, which can introduce unintended indentation and conflicts with the intended spacing tweaks.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR adjusts the Voicemail task panel UI to reflect QA feedback by removing iconography from action buttons and introducing a small spacing/grouping tweak to the panel sections.

Changes:

  • Removed Call/Voicemail icons (and related theme/icon imports) from the voicemail action buttons.
  • Grouped voicemail panel sections into logical blocks via a new SectionGroup wrapper.
  • Added SectionGroup styling in the shared Twilio task panel styles to control inter-group spacing.
File summaries
File Description
plugin-hrm-form/src/voicemail/VoicemailTaskPanel.tsx Removes button icons and reorganizes the voicemail task panel layout into section groups.
plugin-hrm-form/src/styles/twilioTaskPanel.tsx Introduces SectionGroup styling used by the voicemail task panel for spacing/grouping.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread plugin-hrm-form/src/voicemail/VoicemailTaskPanel.tsx
@stephenhand
stephenhand requested a lite review from Copilot September 4, 2026 07:36
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment on lines +27 to +29
export const SectionGroup = styled('div')`
margin-bottom: 8px;
`;
Comment on lines +81 to +83
<SectionGroup>
<Section>
<SectionHeader>
Copilot stopped reviewing on behalf of stephenhand due to an error September 4, 2026 07:57
@stephenhand
stephenhand merged commit b126926 into master Sep 4, 2026
25 checks passed
@stephenhand
stephenhand deleted the CHI-3945-ui_fixes branch September 4, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants