Skip to content

CHI-3945: Tweak styles for QA feedback #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenhand merged 3 commits into from
Sep 4, 2026
+69 −66
Merged

CHI-3945: Tweak styles for QA feedback #4660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df75cef
Tweak styles for QA feedback
stephenhand Sep 3, 2026
7af9017
Merge branch 'master' into CHI-3945-ui_fixes
stephenhand Sep 4, 2026
534baf5
Remove empty span elements in voicemail task panel
stephenhand Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions plugin-hrm-form/src/styles/twilioTaskPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ export const PanelContainer = styled('div')`
`;
PanelContainer.displayName = 'PanelContainer';

export const SectionGroup = styled('div')`
margin-bottom: 8px;
`;
Comment on lines +27 to +29

SectionGroup.displayName = 'SectionGroup';

export const Section = styled('div')`
margin-bottom: 1rem;
`;
Expand Down
129 changes: 63 additions & 66 deletions plugin-hrm-form/src/voicemail/VoicemailTaskPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@ import { RecordingSection } from '../components/contact/MediaSection';
import { RootState } from '../states';
import selectContactByTaskSid from '../states/contacts/selectContactByTaskSid';
import { isS3StoredRecording } from '../types/types';
import { PanelContainer, Section, SectionHeader } from '../styles/twilioTaskPanel';
import VoicemailIcon from '../components/common/icons/VoicemailIcon';
import CallIcon from '../components/common/icons/CallIcon';
import HrmTheme from '../styles/HrmTheme';
import { PanelContainer, Section, SectionGroup, SectionHeader } from '../styles/twilioTaskPanel';
import { createVoicemailSchedule } from '../services/scheduledJobsService';
import { VoicemailActionsNotifications } from './setUpVoicemailComponents';

Expand Down Expand Up @@ -81,71 +78,71 @@ const VoicemailTaskPanel: React.FC<Props> = ({ task }) => {
return (
<PanelContainer key="voicemail-actions">
<FlexBox justifyContent="center" flexDirection="column" paddingTop="20px">
<Section>
<SectionHeader>
<Flex.Template code="TaskPanel-ActiveVoicemail-RecordingLabel" />
</SectionHeader>
<div>
<RecordingSection
contactId={contact.savedContact.id}
externalStoredRecording={externalStoredRecording}
autoLoad
/>
</div>
</Section>
<Section>
<SectionHeader>
<Flex.Template code="TaskPanel-ActiveVoicemail-CallerPhoneNumberLabel" />
</SectionHeader>
<p>{from}</p>
</Section>
<Section>
<SectionHeader>
<Flex.Template code="TaskPanel-ActiveVoicemail-ReceivedTimeLabel" />
</SectionHeader>
<p>
<Flex.Template code={receivedDate} />
</p>
</Section>
{callbackAttempts.length < maxCallbackAttempts && !Flex.TaskHelper.isInWrapupMode(task) && (
<>
<Section>
<PrimaryButton fullWidth={true} onClick={onClickCallBack}>
<CallIcon width="16px" height="16px" color={HrmTheme.buttonColors.primary.textColor} />
<span style={{ width: '10px' }} />
<Flex.Template code="TaskPanel-ActiveVoicemail-CallBack" phoneNumber={from} />
</PrimaryButton>
</Section>
<Section>
<SecondaryButton fullWidth={true} onClick={onClickRetryLater}>
<VoicemailIcon width="16px" height="16px" color={HrmTheme.buttonColors.secondary.textColor} />
<span style={{ width: '10px' }} />
<Flex.Template code="TaskPanel-ActiveVoicemail-RetryLater" />
</SecondaryButton>
</Section>
</>
)}
<Section>
<SectionHeader>
<Flex.Template code="TaskPanel-ActiveVoicemail-CallbackAttemptListLabel" />
</SectionHeader>
{callbackAttempts.length ? (
callbackAttempts.map((attempt, idx) => (
<p key={`attempt-${idx}`}>
<Flex.Template
code="TaskPanel-ActiveVoicemail-CallbackAttemptListItem"
attemptTime={format(parseISO(attempt[1]), DATE_DISPLAY_FORMAT)}
attemptNo={idx + 1}
maxAttempts={maxCallbackAttempts}
/>
</p>
))
) : (
<SectionGroup>
<Section>
<SectionHeader>
Comment on lines +81 to +83
<Flex.Template code="TaskPanel-ActiveVoicemail-RecordingLabel" />
</SectionHeader>
<div>
<RecordingSection
contactId={contact.savedContact.id}
externalStoredRecording={externalStoredRecording}
autoLoad
/>
</div>
</Section>
<Section>
<SectionHeader>
<Flex.Template code="TaskPanel-ActiveVoicemail-CallerPhoneNumberLabel" />
</SectionHeader>
<p>{from}</p>
</Section>
<Section>
<SectionHeader>
<Flex.Template code="TaskPanel-ActiveVoicemail-ReceivedTimeLabel" />
</SectionHeader>
<p>
<Flex.Template code="TaskPanel-ActiveVoicemail-CallbackAttemptListPlaceholder" />
<Flex.Template code={receivedDate} />
</p>
</Section>
{callbackAttempts.length < maxCallbackAttempts && !Flex.TaskHelper.isInWrapupMode(task) && (
<>
<Section>
<PrimaryButton fullWidth={true} onClick={onClickCallBack}>
<Flex.Template code="TaskPanel-ActiveVoicemail-CallBack" phoneNumber={from} />
</PrimaryButton>
</Section>
<Section>
<SecondaryButton fullWidth={true} onClick={onClickRetryLater}>
<Flex.Template code="TaskPanel-ActiveVoicemail-RetryLater" />
</SecondaryButton>
</Section>
Comment thread
Copilot marked this conversation as resolved.
</>
)}
</Section>
</SectionGroup>
<SectionGroup>
<Section>
<SectionHeader>
<Flex.Template code="TaskPanel-ActiveVoicemail-CallbackAttemptListLabel" />
</SectionHeader>
{callbackAttempts.length ? (
callbackAttempts.map((attempt, idx) => (
<p key={`attempt-${idx}`}>
<Flex.Template
code="TaskPanel-ActiveVoicemail-CallbackAttemptListItem"
attemptTime={format(parseISO(attempt[1]), DATE_DISPLAY_FORMAT)}
attemptNo={idx + 1}
maxAttempts={maxCallbackAttempts}
/>
</p>
))
) : (
<p>
<Flex.Template code="TaskPanel-ActiveVoicemail-CallbackAttemptListPlaceholder" />
</p>
)}
</Section>
</SectionGroup>
</FlexBox>
</PanelContainer>
);
Expand Down
Loading