Skip to content

CHI-3982: UI fixes - #4666

Merged
stephenhand merged 4 commits into
masterfrom
CHI-3982-ui_fixes
Sep 4, 2026
Merged

CHI-3982: UI fixes#4666
stephenhand merged 4 commits into
masterfrom
CHI-3982-ui_fixes

Conversation

@stephenhand

Copy link
Copy Markdown
Collaborator

Description

Fix height of PhoneInputDialog when tabs are present
Focus close button when opening PhoneInputDialog
Tweak alignment of close button on PhoneInputDialog

Checklist

  • Corresponding issue has been opened
  • New tests added
  • [n/a] Feature flags added
  • [n/a] Strings are localized
  • [n/a] Tested for chat contacts
  • Tested for call contacts

Other Related Issues

None

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

Copilot AI lite review requested due to automatic review settings September 4, 2026 16:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are localized UI adjustments with low blast radius, and the remaining feedback is minor maintainability cleanup with straightforward fixes.

Pull request overview

This PR applies small UI/UX adjustments to the conference call PhoneInputDialog in plugin-hrm-form, aiming to improve layout stability when tabs are shown and to improve keyboard focus behavior when the dialog opens.

Changes:

  • Add a focus hook and wire it to the dialog close button so it receives focus on open.
  • Adjust close button inline styling for alignment.
  • Wrap the tabbed content in a fixed-height container to stabilize dialog height when tabs are present.
File summaries
File Description
plugin-hrm-form/src/components/Conference/ConferenceActions/PhoneInputDialog.tsx Adds close-button focus handling and tab-container height/alignment tweaks to address dialog UI issues.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

stephenhand and others added 2 commits September 4, 2026 17:42
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@stephenhand
stephenhand merged commit 41b5670 into master Sep 4, 2026
25 checks passed
@stephenhand
stephenhand deleted the CHI-3982-ui_fixes branch September 4, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants