CHI-3982: UI fixes - #4666
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are localized UI adjustments with low blast radius, and the remaining feedback is minor maintainability cleanup with straightforward fixes.
Pull request overview
This PR applies small UI/UX adjustments to the conference call PhoneInputDialog in plugin-hrm-form, aiming to improve layout stability when tabs are shown and to improve keyboard focus behavior when the dialog opens.
Changes:
- Add a focus hook and wire it to the dialog close button so it receives focus on open.
- Adjust close button inline styling for alignment.
- Wrap the tabbed content in a fixed-height container to stabilize dialog height when tabs are present.
File summaries
| File | Description |
|---|---|
| plugin-hrm-form/src/components/Conference/ConferenceActions/PhoneInputDialog.tsx | Adds close-button focus handling and tab-container height/alignment tweaks to address dialog UI issues. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix height of PhoneInputDialog when tabs are present
Focus close button when opening PhoneInputDialog
Tweak alignment of close button on PhoneInputDialog
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P