Skip to content

CHI-3982: UI fixes #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenhand merged 4 commits into from
Sep 4, 2026
Merged

CHI-3982: UI fixes #4666

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5479192
Tweak styles for QA feedback
stephenhand Sep 4, 2026
4cd0df4
Tweak PhoneInputDialog tabbing behaviour
stephenhand Sep 4, 2026
f2cf81e
Fix height in PhoneInputDialog component
stephenhand Sep 4, 2026
6f46ba5
Remove aria-label from CloseButton component
stephenhand Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 27 additions & 13 deletions plugin-hrm-form/src/components/Conference/ConferenceActions/PhoneInputDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {
import type { QuickDialOption } from '../../../states/configuration/reducer';
import { lookupTranslation } from '../../../translations';
import { StyledTabs } from '../../search/styles';
import useFocus from '../../../utils/useFocus';

type PhoneDialogProps = {
targetNumber: string;
Expand Down Expand Up @@ -71,6 +72,8 @@ const PhoneInputDialog: React.FC<PhoneDialogProps> = ({
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

const focusRef = useFocus();

const handleTabChange = (value: TabValue) => {
setActiveTab(value);
if (value === 'quickDial' && quickDialOptions.length > 0) {
Expand Down Expand Up @@ -124,22 +127,33 @@ const PhoneInputDialog: React.FC<PhoneDialogProps> = ({
<Bold>
<Template code="Conference-AddConferenceCallParticipant" />
</Bold>
<CloseButton onClick={() => setIsDialogOpen(false)} aria-label="CloseButton" style={{ marginLeft: 'auto' }} />
<CloseButton
buttonRef={focusRef}
onClick={() => setIsDialogOpen(false)}
style={{ marginLeft: 'auto', marginRight: 0, paddingRight: 0 }}
/>
Comment thread
Copilot marked this conversation as resolved.
</Row>
{showTabs ? (
<StyledTabs
selectedTabName={activeTab}
onTabSelected={handleTabChange}
alignment="center"
keepTabsMounted={false}
<div
style={{
// Explicit height is required to prevent the Twilio Tabs content from collapsing in this dialog.
height: 108,
}}
>
Comment thread
Copilot marked this conversation as resolved.
<TwilioTab uniqueName="quickDial" label={<Template code={QUICK_DIAL_TAB_KEY} />} key="quickDial">
{hasQuickDial && renderQuickDial()}
</TwilioTab>
<TwilioTab uniqueName="enterNumber" label={<Template code={ENTER_NUMBER_TAB_KEY} key="enterNumber" />}>
{enableManualDial && renderManualDial()}
</TwilioTab>
</StyledTabs>
<StyledTabs
selectedTabName={activeTab}
onTabSelected={handleTabChange}
alignment="center"
keepTabsMounted={false}
>
<TwilioTab uniqueName="quickDial" label={<Template code={QUICK_DIAL_TAB_KEY} />} key="quickDial">
{hasQuickDial && renderQuickDial()}
</TwilioTab>
<TwilioTab uniqueName="enterNumber" label={<Template code={ENTER_NUMBER_TAB_KEY} key="enterNumber" />}>
{enableManualDial && renderManualDial()}
</TwilioTab>
</StyledTabs>
</div>
) : (
<>
{hasQuickDial && renderQuickDial()}
Expand Down
Loading