Repository navigation
fix(ci): refresh stale Checkout and README proof artifacts - #1150
Conversation
|
No actionable comments were generated in the recent review.
|
|
Thank you for the carefully scoped fixes and for distinguishing constructed reproductions, CI results, and personal acceptance. We have reviewed the value and maintenance cost of #1146–#1151 and agree with these bounded directions:
These are scope agreements, not final approval or a claim that we reran your full suites. Please provide your own review/accountability confirmation for the submitted changes and explanations, including the recorded visible outcomes where applicable, and mark the ready items ready for review. One concise reply explicitly covering these six PRs is sufficient; no six separate acknowledgements are needed. Keep anything you have not personally reviewed as Draft and identify the remaining gap. Please sequence the generated-output overlap between #1150 and #1151, rebuilding from the combined source when integration requires it rather than independently chasing the same conflicts. Reuse valid existing evidence at its recorded revision and rerun only what a new diff/base invalidates, together with required final-head CI. No new five-project Agent benchmark is requested for these bounded fixes, and skipped CI coverage should continue to be identified accurately. Thanks again. The intended integration target remains dev, with #1150 and #1151 taking priority. |
|
Scope acknowledged. I have personally reviewed the changes, explanations and recorded visible outcomes of #1150 and #1151, understand their impact, and can answer questions about them. Both are now ready for review, with successful CI on unchanged heads The agreed integration order is #1150 first, then #1151. Generated-output overlap should be resolved by rebuilding from the combined source when integration requires it. The existing evidence and explicit skip limits remain pinned to their tested revisions; any new diff or base must be accounted for together with required final-head CI. This personal confirmation covers #1150 and #1151 only; #1146–#1149 are not included. BlueboxC |
Problem and value
The full regression shard on #1147 and #1148 fails because the checked-in Checkout Architecture comparison and README motion-proof receipts do not match current
devinputs. Both failures reproduce on unchanged base847146aeb93b492592adb78dc220f57e4a8b4636, independently of those evidence-link fixes. Example: failed full-regression shard.Regenerate the Checkout HTML/receipt with the existing comparison command and recapture the README GIF/receipt from the current Gallery artifacts. This is a separate generated-only repair; it does not change runtime, validators, test acceptance, or source fixtures.
Related: #900. This PR refreshes existing outputs; it does not duplicate that issue's proposed freshness-gate work. Checked all 128 open PR file lists and relevant Viewer/builder patches. Other PRs regenerate these paths for their own feature changes; none supplies this four-file refresh from the current unchanged base.
The maintainer agreed to this scope. The agreed integration order is #1150 first, then #1151; shared generated outputs should be rebuilt from the combined source when integration requires it.
Contributor review
Stability impact
Generated-only maintenance. The authoritative source and existing behavior are unchanged. Existing tests already discriminate the stale outputs, so they are reused without adding duplicate assertions or weakening checks. The code-simplification check is inapplicable to generated-only output.
Tests run
Base:
847146aeb93b492592adb78dc220f57e4a8b4636. Candidate:4c22ebef101f6e60c0d660e659e215d7759c605f.node --test --test-name-pattern='checked-in Checkout compare artifact|README motion proof is compact' test/architecture-delta.test.mjs test/readme-showcase.test.mjsfails for both stale artifacts.node --test test/architecture-delta.test.mjs test/readme-showcase.test.mjs test/gallery.test.mjs: 55 pass, 0 fail, 1 skipped. The skipped Git-for-Windows discovery scenario requires native Windows; no Windows result is claimed here.1.3.1-e00f703), native Chrome, and temporary ffmpeg 7.1 from the hash-verified imageio-ffmpeg 0.7.0 macOS ARM64 wheel.Visual evidence
The before/after GIFs can be compared directly in the diff. Matched frames 9, 27 and 45 were inspected at the same 960×540 dark embedded scene settings; the three scenes, captions and selected relationships remain visible. Contributor personal review, including the recorded visible outcomes, is confirmed. This is fixed-input output freshness, not an Agent generation-quality benchmark.
Generated artifacts
Only
examples/checkout-platform-delta.html, its receipt, anddocs/assets/archify-live-proof.gif/.jsonare regenerated with the existing builders. Gallery inputs are unchanged and their existing reproduction tests pass. Packagedarchify/source is unchanged, soarchify.zipis unchanged.BlueboxC