Repository navigation
fix: project naming, package metadata, and build scripts - #106
Open
matejstastny wants to merge 19 commits into
Open
matejstastny wants to merge 19 commits into
matejstastny wants to merge 19 commits into
Conversation
…tor, fixed absolute path references and couple of other things
CPrutean
approved these changes
Oct 8, 2026
CPrutean
left a comment
Member
There was a problem hiding this comment.
Good work, description was very lengthy for what changed. One thing I would change however is not removing the testing requirement entirely but instead keep the testing and make a new issue in the repo concerning unit tests. Each node should have its own unit tests and they should all pass. Implement this before merge
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the project from
urc-2023toviatorthroughout the repo, fills in package metadata, cleans up build/launch scripts, and removes unused test boilerplate.Rename
urc-2023→viator/home/trickfire/urc-2023→/home/trickfire/viator) in.devcontainer/devcontainer.json,.devcontainer/docker-compose.yml,.devcontainer/trickfire-can-sudoers,.devcontainer/trickfire.bashrc,.vscode/settings.jsonurc-2023toviatorREADME.mdand docs (architecture.mdx,getting-started.mdx,launching.mdx) to referenceviatorinstead ofurc-2023, and updated doc links from/urc-2023/...to/viator/...Package metadata
TODO: Package descriptionandTODO: License declarationplaceholders inpackage.xmlandsetup.pyforarm,camera,can_moteus,can_rmdx8,drivebase,heartbeat,mission_control_updater,custom_interfaces,viator_launchApache-2.0and added the Apache 2.0LICENSEfile at the repo roottfrbtcs@uw.eduacross all packagesexample_nodeexec_depend fromviator_launch/package.xmlBuild/launch scripts
Makefile: addedcleantarget (rm -rf build install log), renamedsync-orintarget tosyncscripts/build.sh:cdinto repo root before building, use relative--base-paths .instead of hardcoded pathscripts/launch.sh:cdinto repo root, use relativeinstall/setup.bash, exportRCUTILS_COLORIZED_OUTPUT=1for colored logs, removed commented-outmodprobe/ip linklines, removed--log-level rosbridge_websocket:=warnflagscripts/setup-can-network.sh: addedset -escripts/sync-to-orin.sh: hardcodedREMOTE_IP, madeREMOTE_PATHdefault to/home/trickfire/viator, added--deleteto rsyncDevcontainer
.devcontainer/Dockerfile: addedros-humble-cv-bridgeapt package, added ROS lib path told.so.conf.dand ranldconfig, pinnednumpy<2in pip install.devcontainer/devcontainer.json: changedpostCreateCommandfrompre-commit installtomake hooks.devcontainer/trickfire-can-sudoers: replaced theDefaults!...env_deleteline withDefaults env_keep+="PYTHONPATH AMENT_PREFIX_PATH"Code changes
src/camera/package.xml: addedrclpy,cv_bridge,sensor_msgsdependssrc/heartbeat/heartbeat/heartbeat.py:_connection_lostnow startsTrueinstead ofFalse; the "Connection active" log only fires atINFOon the transition into connected state, subsequent ticks log atDEBUGsrc/viator_launch/launch/robot.launch.py: commented outcan_moteus_nodein the launch description (arm not implemented yet), removed a stray blank lineTest cleanup
test_copyright.pyfromarm,camera,can_moteus,can_rmdx8,drivebase,heartbeat,mission_control_updater,viator_launchtest_flake8.pyandtest_pep257.pyfromheartbeatament_copyright/ament_flake8/ament_pep257/python3-pytesttest_depends andtests_require=["pytest"]from all packages