Skip to content

fix: project naming, package metadata, and build scripts - #106

Open
matejstastny wants to merge 19 commits into
mainfrom
fix/modernizations-fix
Open

matejstastny wants to merge 19 commits into
mainfrom
fix/modernizations-fix

Conversation

@matejstastny

@matejstastny matejstastny commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Summary

Renames the project from urc-2023 to viator throughout the repo, fills in package metadata, cleans up build/launch scripts, and removes unused test boilerplate.

Rename urc-2023 → viator

  • Updated all absolute path references (/home/trickfire/urc-2023 → /home/trickfire/viator) in .devcontainer/devcontainer.json, .devcontainer/docker-compose.yml, .devcontainer/trickfire-can-sudoers, .devcontainer/trickfire.bashrc, .vscode/settings.json
  • Renamed Docker image/container references from urc-2023 to viator
  • Updated README.md and docs (architecture.mdx, getting-started.mdx, launching.mdx) to reference viator instead of urc-2023, and updated doc links from /urc-2023/... to /viator/...

Package metadata

  • Filled out TODO: Package description and TODO: License declaration placeholders in package.xml and setup.py for arm, camera, can_moteus, can_rmdx8, drivebase, heartbeat, mission_control_updater, custom_interfaces, viator_launch
  • Set license to Apache-2.0 and added the Apache 2.0 LICENSE file at the repo root
  • Unified maintainer email to tfrbtcs@uw.edu across all packages
  • Removed example_node exec_depend from viator_launch/package.xml

Build/launch scripts

  • Makefile: added clean target (rm -rf build install log), renamed sync-orin target to sync
  • scripts/build.sh: cd into repo root before building, use relative --base-paths . instead of hardcoded path
  • scripts/launch.sh: cd into repo root, use relative install/setup.bash, export RCUTILS_COLORIZED_OUTPUT=1 for colored logs, removed commented-out modprobe/ip link lines, removed --log-level rosbridge_websocket:=warn flag
  • scripts/setup-can-network.sh: added set -e
  • scripts/sync-to-orin.sh: hardcoded REMOTE_IP, made REMOTE_PATH default to /home/trickfire/viator, added --delete to rsync

Devcontainer

  • .devcontainer/Dockerfile: added ros-humble-cv-bridge apt package, added ROS lib path to ld.so.conf.d and ran ldconfig, pinned numpy<2 in pip install
  • .devcontainer/devcontainer.json: changed postCreateCommand from pre-commit install to make hooks
  • .devcontainer/trickfire-can-sudoers: replaced the Defaults!...env_delete line with Defaults env_keep+="PYTHONPATH AMENT_PREFIX_PATH"

Code changes

  • src/camera/package.xml: added rclpy, cv_bridge, sensor_msgs depends
  • src/heartbeat/heartbeat/heartbeat.py: _connection_lost now starts True instead of False; the "Connection active" log only fires at INFO on the transition into connected state, subsequent ticks log at DEBUG
  • src/viator_launch/launch/robot.launch.py: commented out can_moteus_node in the launch description (arm not implemented yet), removed a stray blank line

Test cleanup

  • Removed test_copyright.py from arm, camera, can_moteus, can_rmdx8, drivebase, heartbeat, mission_control_updater, viator_launch
  • Removed test_flake8.py and test_pep257.py from heartbeat
  • Removed corresponding ament_copyright/ament_flake8/ament_pep257/python3-pytest test_depends and tests_require=["pytest"] from all packages

@matejstastny
matejstastny requested a review from CPrutean October 7, 2026 01:21
@matejstastny matejstastny self-assigned this Oct 7, 2026
@matejstastny matejstastny added the Fix Bug fixes label Oct 7, 2026
@matejstastny matejstastny changed the title fix: general launch bugs fixes chore: modernize project naming, package metadata, and build scripts Oct 7, 2026
@matejstastny matejstastny changed the title chore: modernize project naming, package metadata, and build scripts fix: project naming, package metadata, and build scripts Oct 7, 2026

@CPrutean CPrutean left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, description was very lengthy for what changed. One thing I would change however is not removing the testing requirement entirely but instead keep the testing and make a new issue in the repo concerning unit tests. Each node should have its own unit tests and they should all pass. Implement this before merge

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants